linux-kernel - Re: [PATCH] power: cpupower: utils: Add malloc return value check

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <e07df85d-9b98-75b8-d773-1124278aeb2e@linuxfoundation.org>
Date:   Tue, 18 Oct 2022 14:33:02 -0600
From:   Shuah Khan <skhan@...uxfoundation.org>
To:     Li kunyu <kunyu@...china.com>, shuah@...nel.org
Cc:     trenn@...e.com, ray.huang@....com, linux-pm@...r.kernel.org,
        linux-kernel@...r.kernel.org,
        Shuah Khan <skhan@...uxfoundation.org>
Subject: Re: [PATCH] power: cpupower: utils: Add malloc return value check

On 10/13/22 22:29, Li kunyu wrote:
> Add the check and judgment statement of malloc return value.
> 
> Signed-off-by: Li kunyu <kunyu@...china.com>
> ---
>   tools/power/cpupower/utils/helpers/misc.c | 4 ++++
>   1 file changed, 4 insertions(+)
> 
> diff --git a/tools/power/cpupower/utils/helpers/misc.c b/tools/power/cpupower/utils/helpers/misc.c
> index 9547b29254a7..eafdbd6d760c 100644
> --- a/tools/power/cpupower/utils/helpers/misc.c
> +++ b/tools/power/cpupower/utils/helpers/misc.c
> @@ -139,6 +139,8 @@ void print_online_cpus(void)
>   
>   	str_len = online_cpus->size * 5;
>   	online_cpus_str = (void *)malloc(sizeof(char) * str_len);
> +	if (unlikely(!online_cpus_str))
> +		return;

You don't need unlikely here.

>   
>   	if (!bitmask_isallclear(online_cpus)) {
>   		bitmask_displaylist(online_cpus_str, str_len, online_cpus);
> @@ -157,6 +159,8 @@ void print_offline_cpus(void)
>   
>   	str_len = offline_cpus->size * 5;
>   	offline_cpus_str = (void *)malloc(sizeof(char) * str_len);
> +	if (unlikely(!offline_cpus_str))
> +		return;

You don't need unlikely here.

>   
>   	if (!bitmask_isallclear(offline_cpus)) {
>   		bitmask_displaylist(offline_cpus_str, str_len, offline_cpus);

thanks,
-- Shuah