linux-kernel - Re: [PATCH 1/2] rv/dot2c: Make automaton definition static

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20221018182553.06f13a50@gandalf.local.home>
Date:   Tue, 18 Oct 2022 18:25:53 -0400
From:   Steven Rostedt <rostedt@...dmis.org>
To:     Daniel Bristot de Oliveira <bristot@...nel.org>
Cc:     linux-kernel@...r.kernel.org, linux-trace-devel@...r.kernel.org,
        kernel test robot <lkp@...el.com>
Subject: Re: [PATCH 1/2] rv/dot2c: Make automaton definition static

On Tue, 23 Aug 2022 17:20:28 +0200
Daniel Bristot de Oliveira <bristot@...nel.org> wrote:

> Monitor's automata definition is only used locally, so make dot2c generate
> a static definition.
> 
> Link: https://lore.kernel.org/all/202208210332.gtHXje45-lkp@intel.com
> Link: https://lore.kernel.org/all/202208210358.6HH3OrVs-lkp@intel.com
> 

Somehow this fell through the cracks.

Daniel, is there any reason I shouldn't pull this in now?

-- Steve

> Cc: Steven Rostedt <rostedt@...dmis.org>
> Fixes: e3c9fc78f096 ("tools/rv: Add dot2c")
> Reported-by: kernel test robot <lkp@...el.com>
> Signed-off-by: Daniel Bristot de Oliveira <bristot@...nel.org>
> ---
>  tools/verification/dot2/dot2c.py | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/tools/verification/dot2/dot2c.py b/tools/verification/dot2/dot2c.py
> index fa73353f7e56..be8a364a469b 100644
> --- a/tools/verification/dot2/dot2c.py
> +++ b/tools/verification/dot2/dot2c.py
> @@ -111,7 +111,7 @@ class Dot2c(Automata):
>  
>      def format_aut_init_header(self):
>          buff = []
> -        buff.append("struct %s %s = {" % (self.struct_automaton_def, self.var_automaton_def))
> +        buff.append("static struct %s %s = {" % (self.struct_automaton_def, self.var_automaton_def))
>          return buff
>  
>      def __get_string_vector_per_line_content(self, buff):