linux-kernel - Re: [PATCH v3] crypto: x86/polyval - Fix crashes when keys are not 16-byte aligned

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <Y08y9yXAimRj3Dih@sol.localdomain>
Date:   Tue, 18 Oct 2022 16:12:55 -0700
From:   Eric Biggers <ebiggers@...nel.org>
To:     Nathan Huckleberry <nhuck@...gle.com>
Cc:     ardb@...nel.org, bgoncalv@...hat.com, bp@...en8.de,
        dave.hansen@...ux.intel.com, davem@...emloft.net,
        herbert@...dor.apana.org.au, hpa@...or.com,
        linux-crypto@...r.kernel.org, linux-kernel@...r.kernel.org,
        mingo@...hat.com, tglx@...utronix.de, x86@...nel.org
Subject: Re: [PATCH v3] crypto: x86/polyval - Fix crashes when keys are not
 16-byte aligned

On Tue, Oct 18, 2022 at 04:04:12PM -0700, Nathan Huckleberry wrote:
> crypto_tfm::__crt_ctx is not guaranteed to be 16-byte aligned on x86-64.
> This causes crashes due to movaps instructions in clmul_polyval_update.
> 
> Add logic to align polyval_tfm_ctx to 16 bytes.
> 
> Fixes: 34f7f6c30112 ("crypto: x86/polyval - Add PCLMULQDQ accelerated implementation of POLYVAL")
> Reported-by: Bruno Goncalves <bgoncalv@...hat.com>
> Signed-off-by: Nathan Huckleberry <nhuck@...gle.com>

Reviewed-by: Eric Biggers <ebiggers@...gle.com>

Please add 'Cc: stable@...r.kernel.org' as well.  (Herbert can do it when
applying this patch, if you don't happen to send another version.)

- Eric