linux-kernel - Re: [PATCH v12 5/6] drm/imx: Introduce i.MX8qm/qxp DPU DRM

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <202210190730.rlLYtBVv-lkp@intel.com>
Date:   Wed, 19 Oct 2022 07:41:19 +0800
From:   kernel test robot <lkp@...el.com>
To:     Liu Ying <victor.liu@....com>, dri-devel@...ts.freedesktop.org,
        devicetree@...r.kernel.org, linux-arm-kernel@...ts.infradead.org,
        linux-kernel@...r.kernel.org
Cc:     kbuild-all@...ts.01.org, p.zabel@...gutronix.de, airlied@...il.com,
        daniel@...ll.ch, robh+dt@...nel.org,
        krzysztof.kozlowski+dt@...aro.org, shawnguo@...nel.org,
        s.hauer@...gutronix.de, kernel@...gutronix.de, festevam@...il.com,
        linux-imx@....com, maarten.lankhorst@...ux.intel.com,
        mripard@...nel.org, tzimmermann@...e.de, guido.gunther@...i.sm,
        marcel.ziswiler@...adex.com, laurentiu.palcu@....nxp.com,
        robh@...nel.org
Subject: Re: [PATCH v12 5/6] drm/imx: Introduce i.MX8qm/qxp DPU DRM

Hi Liu,

I love your patch! Yet something to improve:

[auto build test ERROR on drm-misc/drm-misc-next]
[also build test ERROR on drm/drm-next drm-exynos/exynos-drm-next drm-intel/for-linux-next drm-tip/drm-tip linus/master v6.1-rc1 next-20221018]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch#_base_tree_information]

url:    https://github.com/intel-lab-lkp/linux/commits/Liu-Ying/drm-imx-Introduce-i-MX8qm-qxp-DPU-DRM/20221017-172554
base:   git://anongit.freedesktop.org/drm/drm-misc drm-misc-next
patch link:    https://lore.kernel.org/r/20221017092308.249665-6-victor.liu%40nxp.com
patch subject: [PATCH v12 5/6] drm/imx: Introduce i.MX8qm/qxp DPU DRM
config: arm-randconfig-s042-20221018
compiler: arm-linux-gnueabi-gcc (GCC) 12.1.0
reproduce:
        wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
        chmod +x ~/bin/make.cross
        # apt-get install sparse
        # sparse version: v0.6.4-39-gce1a6720-dirty
        # https://github.com/intel-lab-lkp/linux/commit/e3fd59c6979c1bda8cf747c3437a066c3ce6a5e4
        git remote add linux-review https://github.com/intel-lab-lkp/linux
        git fetch --no-tags linux-review Liu-Ying/drm-imx-Introduce-i-MX8qm-qxp-DPU-DRM/20221017-172554
        git checkout e3fd59c6979c1bda8cf747c3437a066c3ce6a5e4
        # save the config file
        mkdir build_dir && cp config build_dir/.config
        COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-12.1.0 make.cross C=1 CF='-fdiagnostic-prefix -D__CHECK_ENDIAN__' O=build_dir ARCH=arm SHELL=/bin/bash drivers/gpu/drm/imx/dpu/

If you fix the issue, kindly add following tag where applicable
| Reported-by: kernel test robot <lkp@...el.com>

All errors (new ones prefixed by >>):

   drivers/gpu/drm/imx/dpu/dpu-drv.c: In function 'dpu_drm_bind':
>> drivers/gpu/drm/imx/dpu/dpu-drv.c:67:12: error: 'struct drm_device' has no member named 'irq_enabled'
      67 |         drm->irq_enabled = true;
         |            ^~


vim +67 drivers/gpu/drm/imx/dpu/dpu-drv.c

    49	
    50	static int dpu_drm_bind(struct device *dev)
    51	{
    52		struct dpu_drm_device *dpu_drm;
    53		struct drm_device *drm;
    54		struct dpu_drm_drv_data *drv_data = dev_get_drvdata(dev);
    55		int ret;
    56	
    57		dpu_drm = devm_drm_dev_alloc(dev, &dpu_drm_driver,
    58					     struct dpu_drm_device, base);
    59		if (IS_ERR(dpu_drm)) {
    60			ret = PTR_ERR(dpu_drm);
    61			DRM_DEV_ERROR(dev, "failed to alloc drm device: %d\n", ret);
    62			return ret;
    63		}
    64	
    65		drm = &dpu_drm->base;
    66	
  > 67		drm->irq_enabled = true;
    68	
    69		ret = dpu_kms_prepare(dpu_drm, &drv_data->crtc_np_list);
    70		if (ret) {
    71			if (ret != -EPROBE_DEFER)
    72				DRM_DEV_ERROR(dev, "failed to prepare kms: %d\n", ret);
    73			return ret;
    74		}
    75	
    76		ret = component_bind_all(dev, dpu_drm);
    77		if (ret) {
    78			if (ret != -EPROBE_DEFER)
    79				DRM_DEV_ERROR(dev,
    80					      "failed to bind all components: %d\n",
    81										ret);
    82			return ret;
    83		}
    84	
    85		drm_mode_config_reset(drm);
    86	
    87		drm_kms_helper_poll_init(drm);
    88	
    89		ret = drm_dev_register(drm, 0);
    90		if (ret) {
    91			DRM_DEV_ERROR(dev, "failed to register drm device: %d\n", ret);
    92			goto out_register;
    93		}
    94	
    95		if (legacyfb_depth != 16 && legacyfb_depth != 32) {
    96			DRM_DEV_INFO(dev,
    97				     "Invalid legacyfb_depth.  Defaulting to 32bpp\n");
    98			legacyfb_depth = 32;
    99		}
   100	
   101		drm_fbdev_generic_setup(drm, legacyfb_depth);
   102	
   103		return ret;
   104	
   105	out_register:
   106		drm_kms_helper_poll_fini(drm);
   107		component_unbind_all(dev, NULL);
   108	
   109		return ret;
   110	}
   111	

-- 
0-DAY CI Kernel Test Service
https://01.org/lkp

View attachment "config" of type "text/plain" (164380 bytes)