linux-kernel - [PATCH] platform/chrome: cros_hps_i2c: make remove callback return void

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [thread-next>] [day] [month] [year] [list]

Message-Id: <20221018235237.2274969-1-dcallagh@chromium.org>
Date:   Wed, 19 Oct 2022 10:52:37 +1100
From:   Dan Callaghan <dcallagh@...omium.org>
To:     chrome-platform@...ts.linux.dev
Cc:     LKML <linux-kernel@...r.kernel.org>,
        Sami Kyöstilä <skyostil@...omium.org>,
        Benson Leung <bleung@...omium.org>,
        Tzung-Bi Shih <tzungbi@...nel.org>,
        Dan Callaghan <dcallagh@...omium.org>,
        kernel test robot <lkp@...el.com>
Subject: [PATCH] platform/chrome: cros_hps_i2c: make remove callback return void

Commit ed5c2f5fd10d ("i2c: Make remove callback return void") changed
the return type of the 'remove' callback to void, but this driver was
originally written before that change landed. Update the remove callback
to match.

Fixes: 5f9952548d91 ("platform/chrome: add a driver for HPS")
Reported-by: kernel test robot <lkp@...el.com>
Signed-off-by: Dan Callaghan <dcallagh@...omium.org>
---
 drivers/platform/chrome/cros_hps_i2c.c | 4 +---
 1 file changed, 1 insertion(+), 3 deletions(-)

diff --git a/drivers/platform/chrome/cros_hps_i2c.c b/drivers/platform/chrome/cros_hps_i2c.c
index 92da59d94745..62ccb1acb5de 100644
--- a/drivers/platform/chrome/cros_hps_i2c.c
+++ b/drivers/platform/chrome/cros_hps_i2c.c
@@ -95,7 +95,7 @@ static int hps_i2c_probe(struct i2c_client *client)
 	return 0;
 }
 
-static int hps_i2c_remove(struct i2c_client *client)
+static void hps_i2c_remove(struct i2c_client *client)
 {
 	struct hps_drvdata *hps = i2c_get_clientdata(client);
 
@@ -107,8 +107,6 @@ static int hps_i2c_remove(struct i2c_client *client)
 	 * (i.e. powered on).
 	 */
 	hps_set_power(hps, true);
-
-	return 0;
 }
 
 static int hps_suspend(struct device *dev)

base-commit: c7e2618e12562ba6f9d230d8ed4257dfa94d2d9d
-- 
2.38.0.413.g74048e4d9e-goog