linux-kernel - Re: [PATCHv3 5/8] documentation: Add recompression documentation

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <Y04N4YkBFl2+STBB@google.com>
Date:   Tue, 18 Oct 2022 11:22:25 +0900
From:   Sergey Senozhatsky <senozhatsky@...omium.org>
To:     Andrew Morton <akpm@...ux-foundation.org>,
        Minchan Kim <minchan@...nel.org>
Cc:     Sergey Senozhatsky <senozhatsky@...omium.org>,
        Nitin Gupta <ngupta@...are.org>, linux-kernel@...r.kernel.org,
        linux-mm@...ck.org
Subject: Re: [PATCHv3 5/8] documentation: Add recompression documentation

On (22/10/09 18:07), Sergey Senozhatsky wrote:
[..]
> diff --git a/drivers/block/zram/zram_drv.c b/drivers/block/zram/zram_drv.c
> index 12368e773f3d..143c33bd6783 100644
> --- a/drivers/block/zram/zram_drv.c
> +++ b/drivers/block/zram/zram_drv.c
> @@ -1623,9 +1623,7 @@ static int zram_bvec_write(struct zram *zram, struct bio_vec *bvec,
>   *
>   * Corresponding ZRAM slot should be locked.
>   */
> -static int zram_recompress(struct zram *zram,
> -			   u32 index,
> -			   struct page *page,
> +static int zram_recompress(struct zram *zram, u32 index, struct page *page,
>  			   int size_watermark)
>  {
>  	unsigned long handle_prev;
> @@ -1708,8 +1706,7 @@ static int zram_recompress(struct zram *zram,
>  
>  static ssize_t recompress_store(struct device *dev,
>  				struct device_attribute *attr,
> -				const char *buf,
> -				size_t len)
> +				const char *buf, size_t len)
>  {
>  	struct zram *zram = dev_to_zram(dev);
>  	unsigned long nr_pages = zram->disksize >> PAGE_SHIFT;

D'oh, this patch should not contain any code changes, only
documentation updates. It's the previous patch in the series
that should contain these coding-style tweaks. Rebasing did
not go spectacularly well here...

Andrew, what's the best way to handle this?