[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <202210171948.E275139C0D@keescook>
Date: Mon, 17 Oct 2022 19:49:35 -0700
From: Kees Cook <keescook@...omium.org>
To: "Gustavo A. R. Silva" <gustavoars@...nel.org>
Cc: Kalle Valo <kvalo@...nel.org>,
"David S. Miller" <davem@...emloft.net>,
Eric Dumazet <edumazet@...gle.com>,
Jakub Kicinski <kuba@...nel.org>,
Paolo Abeni <pabeni@...hat.com>, netdev@...r.kernel.org,
linux-wireless@...r.kernel.org, linux-kernel@...r.kernel.org,
linux-hardening@...r.kernel.org
Subject: Re: [PATCH 5/6][next] zd1201: Avoid clashing function prototypes
On Mon, Oct 17, 2022 at 03:35:57PM -0500, Gustavo A. R. Silva wrote:
> [...]
> @@ -1678,12 +1682,11 @@ static int zd1201_get_maxassoc(struct net_device *dev,
> }
>
> static const iw_handler zd1201_private_handler[] = {
> - (iw_handler) zd1201_set_hostauth, /* ZD1201SIWHOSTAUTH */
> - (iw_handler) zd1201_get_hostauth, /* ZD1201GIWHOSTAUTH */
> - (iw_handler) zd1201_auth_sta, /* ZD1201SIWAUTHSTA */
> - (iw_handler) NULL, /* nothing to get */
> - (iw_handler) zd1201_set_maxassoc, /* ZD1201SIMAXASSOC */
> - (iw_handler) zd1201_get_maxassoc, /* ZD1201GIMAXASSOC */
> + IW_HANDLER(ZD1201SIWHOSTAUTH, zd1201_set_hostauth),
> + IW_HANDLER(ZD1201GIWHOSTAUTH, zd1201_get_hostauth),
> + IW_HANDLER(ZD1201SIWAUTHSTA, zd1201_auth_sta),
> + IW_HANDLER(ZD1201SIWMAXASSOC, zd1201_set_maxassoc),
> + IW_HANDLER(ZD1201GIWMAXASSOC, zd1201_get_maxassoc),
> };
Like with the others, leave these as-is...
--
Kees Cook
Powered by blists - more mailing lists