linux-kernel - [mark:arm64/ftrace/per-callsite-ops 5/8] kernel/trace/ftrace.c:2486:1: error: conflicting types for 'ftrace_find_unique_ops'; have 'struct ftrace_ops *(struct dyn

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [day] [month] [year] [list]

Date:   Tue, 18 Oct 2022 11:38:27 +0800
From:   kernel test robot <lkp@...el.com>
To:     Mark Rutland <mark.rutland@....com>
Cc:     kbuild-all@...ts.01.org, linux-kernel@...r.kernel.org
Subject: [mark:arm64/ftrace/per-callsite-ops 5/8]
 kernel/trace/ftrace.c:2486:1: error: conflicting types for
 'ftrace_find_unique_ops'; have 'struct ftrace_ops *(struct dyn_ftrace *)'

tree:   https://git.kernel.org/pub/scm/linux/kernel/git/mark/linux.git arm64/ftrace/per-callsite-ops
head:   6f1081e05f384a1a27dfe00afd807546e97cf1c0
commit: cd905318352510c2e1978493d0b076ef5e0bbc84 [5/8] WIP: ftrace: add DYNAMIC_FTRACE_WITH_CALL_OPS
config: x86_64-rhel-8.3-kunit
compiler: gcc-11 (Debian 11.3.0-8) 11.3.0
reproduce (this is a W=1 build):
        # https://git.kernel.org/pub/scm/linux/kernel/git/mark/linux.git/commit/?id=cd905318352510c2e1978493d0b076ef5e0bbc84
        git remote add mark https://git.kernel.org/pub/scm/linux/kernel/git/mark/linux.git
        git fetch --no-tags mark arm64/ftrace/per-callsite-ops
        git checkout cd905318352510c2e1978493d0b076ef5e0bbc84
        # save the config file
        mkdir build_dir && cp config build_dir/.config
        make W=1 O=build_dir ARCH=x86_64 SHELL=/bin/bash

If you fix the issue, kindly add following tag where applicable
| Reported-by: kernel test robot <lkp@...el.com>

All errors (new ones prefixed by >>):

   In file included from kernel/trace/ftrace.c:29:
   include/linux/ftrace.h:60:50: warning: 'struct dyn_ftrace' declared inside parameter list will not be visible outside of this definition or declaration
      60 | struct ftrace_ops *ftrace_find_unique_ops(struct dyn_ftrace *rec);
         |                                                  ^~~~~~~~~~
   kernel/trace/ftrace.c:307:5: warning: no previous prototype for '__register_ftrace_function' [-Wmissing-prototypes]
     307 | int __register_ftrace_function(struct ftrace_ops *ops)
         |     ^~~~~~~~~~~~~~~~~~~~~~~~~~
   kernel/trace/ftrace.c:350:5: warning: no previous prototype for '__unregister_ftrace_function' [-Wmissing-prototypes]
     350 | int __unregister_ftrace_function(struct ftrace_ops *ops)
         |     ^~~~~~~~~~~~~~~~~~~~~~~~~~~~
>> kernel/trace/ftrace.c:2486:1: error: conflicting types for 'ftrace_find_unique_ops'; have 'struct ftrace_ops *(struct dyn_ftrace *)'
    2486 | ftrace_find_unique_ops(struct dyn_ftrace *rec)
         | ^~~~~~~~~~~~~~~~~~~~~~
   In file included from kernel/trace/ftrace.c:29:
   include/linux/ftrace.h:60:20: note: previous declaration of 'ftrace_find_unique_ops' with type 'struct ftrace_ops *(struct dyn_ftrace *)'
      60 | struct ftrace_ops *ftrace_find_unique_ops(struct dyn_ftrace *rec);
         |                    ^~~~~~~~~~~~~~~~~~~~~~
   kernel/trace/ftrace.c:4088:15: warning: no previous prototype for 'arch_ftrace_match_adjust' [-Wmissing-prototypes]
    4088 | char * __weak arch_ftrace_match_adjust(char *str, const char *search)
         |               ^~~~~~~~~~~~~~~~~~~~~~~~


vim +2486 kernel/trace/ftrace.c

  2484	
  2485	struct ftrace_ops *
> 2486	ftrace_find_unique_ops(struct dyn_ftrace *rec)
  2487	{
  2488		struct ftrace_ops *op, *found = NULL;
  2489		unsigned long ip = rec->ip;
  2490	
  2491		do_for_each_ftrace_op(op, ftrace_ops_list) {
  2492	
  2493			if (hash_contains_ip(ip, op->func_hash)) {
  2494				if (found)
  2495					return NULL;
  2496				found = op;
  2497			}
  2498	
  2499		} while_for_each_ftrace_op(op);
  2500	
  2501		return found;
  2502	}
  2503	

-- 
0-DAY CI Kernel Test Service
https://01.org/lkp

View attachment "config" of type "text/plain" (166925 bytes)