linux-kernel - Re: [PATCH] [PATCH] staging: rts5208: merge unnecessary split line

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <3f65f367-e07f-5b71-ea7c-4f13c23eca8d@inria.fr>
Date:   Tue, 18 Oct 2022 12:11:20 +0200 (CEST)
From:   Julia Lawall <julia.lawall@...ia.fr>
To:     Tanjuate Brunostar <tanjubrunostar0@...il.com>
cc:     gregkh@...uxfoundation.org, linux-staging@...ts.linux.dev,
        linux-kernel@...r.kernel.org, outreachy@...ts.linux.dev
Subject: Re: [PATCH] [PATCH] staging: rts5208: merge unnecessary split line



On Tue, 18 Oct 2022, Tanjuate Brunostar wrote:

> Fix checkpatch warning by merging unnecessary split line in order to
> avoid ending a line of code with a "(". The resulting code does
> not affect readability and is well within the code-style guidelines

Thanks for the patch.

You don't need the extra [PATCH] in the subject line.

Actually, you don't need the parentheses at all, but that might be a
matter of personal taste.

julia

>
> Signed-off-by: Tanjuate Brunostar <tanjubrunostar0@...il.com>
> ---
>  drivers/staging/rts5208/sd.c | 3 +--
>  1 file changed, 1 insertion(+), 2 deletions(-)
>
> diff --git a/drivers/staging/rts5208/sd.c b/drivers/staging/rts5208/sd.c
> index d1fafd530c80..4643127a87ca 100644
> --- a/drivers/staging/rts5208/sd.c
> +++ b/drivers/staging/rts5208/sd.c
> @@ -4501,8 +4501,7 @@ int sd_execute_write_data(struct scsi_cmnd *srb, struct rtsx_chip *chip)
>  			sd_card->sd_lock_notify = 1;
>  			if (sd_lock_state &&
>  			    (sd_card->sd_lock_status & SD_LOCK_1BIT_MODE)) {
> -				sd_card->sd_lock_status |= (
> -					SD_UNLOCK_POW_ON | SD_SDR_RST);
> +				sd_card->sd_lock_status |= (SD_UNLOCK_POW_ON | SD_SDR_RST);
>  				if (CHK_SD(sd_card)) {
>  					retval = reset_sd(chip);
>  					if (retval != STATUS_SUCCESS) {
> --
> 2.34.1
>
>
>