linux-kernel - Re: [PATCH] counter: microchip-tcb-capture: Handle Signal1 read and Synapse

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <Y06T1GPSO0ZgSOSs@fedora>
Date:   Tue, 18 Oct 2022 07:53:56 -0400
From:   William Breathitt Gray <william.gray@...aro.org>
To:     Kamel Bouhara <kamel.bouhara@...tlin.com>
Cc:     linux-iio@...r.kernel.org, linux-kernel@...r.kernel.org,
        linux-arm-kernel@...ts.infradead.org, stable@...r.kernel.org,
        stable@...nel.org
Subject: Re: [PATCH] counter: microchip-tcb-capture: Handle Signal1 read and
 Synapse

On Tue, Oct 18, 2022 at 10:13:51AM +0200, Kamel Bouhara wrote:
> On Mon, Oct 17, 2022 at 06:54:04PM -0400, William Breathitt Gray wrote:
> > The signal_read(), action_read(), and action_write() callbacks have been
> > assuming Signal0 is requested without checking. This results in requests
> > for Signal1 returning data for Signal0. This patch fixes these
> > oversights by properly checking for the Signal's id in the respective
> > callbacks and handling accordingly based on the particular Signal
> > requested. The trig_inverted member of the mchp_tc_data is removed as
> > superfluous.
> >
> > Fixes: 106b104137fd ("counter: Add microchip TCB capture counter")
> > Cc: stable@...nel.org
> > Cc: Kamel Bouhara <kamel.bouhara@...tlin.com>
> > Signed-off-by: William Breathitt Gray <william.gray@...aro.org>
> 
> Looks ok to me, thanks.
> 
> Reviewed-by: Kamel Bouhara <kamel.bouhara@...tlin.com>

I'm going to submit a v2 of this patch for the sake of making it a tad
easier to backport and also simpler to handle if a lock is introduced at
a later point for this driver.

William Breathitt Gray

Download attachment "signature.asc" of type "application/pgp-signature" (229 bytes)