linux-kernel - Re: [PATCH v1 1/1] gpio: exar: Allow IO port access

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <Y06ZZQ4q3Ql0sNkm@fedora>
Date:   Tue, 18 Oct 2022 08:17:41 -0400
From:   William Breathitt Gray <william.gray@...aro.org>
To:     Linus Walleij <linus.walleij@...aro.org>,
        Andy Shevchenko <andriy.shevchenko@...ux.intel.com>
Cc:     Qingtao Cao <qingtao.cao.au@...il.com>, linux-gpio@...r.kernel.org,
        linux-kernel@...r.kernel.org, Bartosz Golaszewski <brgl@...ev.pl>
Subject: Re: [PATCH v1 1/1] gpio: exar: Allow IO port access

On Tue, Oct 18, 2022 at 10:29:13AM +0200, Linus Walleij wrote:
> On Mon, Oct 17, 2022 at 7:05 PM Andy Shevchenko
> <andriy.shevchenko@...ux.intel.com> wrote:
> 
> > It's possible that PCI device can provide an IO port resource for
> > the device. regmap MMIO currently uses MMIO by default. With an
> > additional flag we enable support for IO port accesses.
> >
> > Signed-off-by: Andy Shevchenko <andriy.shevchenko@...ux.intel.com>
> 
> Looks clever to me!
> Acked-by: Linus Walleij <linus.walleij@...aro.org>
> I would let William have a look at it as well, as he's worked extensively
> with port-mapped I/O.
> 
> Yours,
> Linus Walleij

I love how simple it is to add IO port support to these drivers now. :-)

Acked-by: William Breathitt Gray <william.gray@...aro.org>

I'm hoping to convert several of the port-mapped GPIO drivers to the
regmap API later this cycle, so it's good to see other modules making
use of this interface as well.

Thanks,

William Breathitt Gray

Download attachment "signature.asc" of type "application/pgp-signature" (229 bytes)