linux-kernel - [QUESTION] kernel can be silence when io hang

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [day] [month] [year] [list]

Message-ID: <034239b5-0d46-51b1-c189-a09f1700083d@huaweicloud.com>
Date:   Wed, 19 Oct 2022 11:06:58 +0800
From:   Yu Kuai <yukuai1@...weicloud.com>
To:     axboe@...nel.dk, linux-block <linux-block@...r.kernel.org>,
        lkml <linux-kernel@...r.kernel.org>, yi.zhang@...wei.com,
        "yukuai (C)" <yukuai3@...wei.com>, jack@...e.cz, hch@...radead.org,
        Ming Lei <ming.lei@...hat.com>
Subject: [QUESTION] kernel can be silence when io hang

Hi, block experts！

In order to prevent false positive hung task warnings for slow io,
following commits forbit hung task checking for io:

1) 
https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/commit/?id=4b1977698ceb
2) 
https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/commit/?id=de6a78b601c5
3) 
https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/commit/?id=e6249cdd46e4

However, if io really hangs, they also forbit the hung task warnings
that will be helpful.

I'm thinking about when hang task should be detected:

1) If io is still in block layer，there are many places that io can be
stalled: blk throttle, get tag, rq_qos_throttle, plug, elevator, hctx. I
think hang task should be detected at least for the case that there is
no io in driver.

2) If io is issued to driver
   a. For the driver that timeout handling is implemented, there is no
need to detect hung task.
   b. For the driver that timeout handling is not implemented
(virtio,virtio_scsi)，there is a real timeout handling in physical
device. So hung task should be detected before the io is issued to lower
device.

Does anyone thinks these thoughts meaningful? Comments and suggestions
are welcomed.

Thanks,

Kuai