linux-kernel - Re: [Patch v7 01/12] net: mana: Add support for auxiliary device

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Wed, 19 Oct 2022 11:29:54 +0800
From:   Yunsheng Lin <linyunsheng@...wei.com>
To:     <longli@...rosoft.com>, "K. Y. Srinivasan" <kys@...rosoft.com>,
        "Haiyang Zhang" <haiyangz@...rosoft.com>,
        Stephen Hemminger <sthemmin@...rosoft.com>,
        Wei Liu <wei.liu@...nel.org>, Dexuan Cui <decui@...rosoft.com>,
        "David S. Miller" <davem@...emloft.net>,
        Jakub Kicinski <kuba@...nel.org>,
        Paolo Abeni <pabeni@...hat.com>,
        Jason Gunthorpe <jgg@...pe.ca>,
        Leon Romanovsky <leon@...nel.org>, <edumazet@...gle.com>,
        <shiraz.saleem@...el.com>, "Ajay Sharma" <sharmaajay@...rosoft.com>
CC:     <linux-hyperv@...r.kernel.org>, <netdev@...r.kernel.org>,
        <linux-kernel@...r.kernel.org>, <linux-rdma@...r.kernel.org>
Subject: Re: [Patch v7 01/12] net: mana: Add support for auxiliary device

On 2022/10/18 3:20, longli@...uxonhyperv.com wrote:
> From: Long Li <longli@...rosoft.com>
> 
> In preparation for supporting MANA RDMA driver, add support for auxiliary
> device in the Ethernet driver. The RDMA device is modeled as an auxiliary
> device to the Ethernet device.

If the RDMA device is a auxiliary device in the Ethernet driver, is there
some type of hw reset that affect both net_device and ib_device?
Is there some kind of handling like pcie hot plug/unplug which already
handles this case, so the reset handling is not needed in the RDMA and
Ethernet driver?


> 
> Reviewed-by: Dexuan Cui <decui@...rosoft.com>
> Signed-off-by: Long Li <longli@...rosoft.com>
> Acked-by: Haiyang Zhang <haiyangz@...rosoft.com>
> ---
> Change log:
> v3: define mana_adev_idx_alloc and mana_adev_idx_free as static
> v7: fix a bug that may assign a negative value to adev->id
> 
>  drivers/net/ethernet/microsoft/Kconfig        |  1 +
>  drivers/net/ethernet/microsoft/mana/gdma.h    |  2 +
>  .../ethernet/microsoft/mana/mana_auxiliary.h  | 10 +++
>  drivers/net/ethernet/microsoft/mana/mana_en.c | 83 ++++++++++++++++++-