linux-kernel - Re: [PATCH 3/6] arm: configs: spear6xx: Enable PL110 display controller

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Wed, 19 Oct 2022 15:52:12 +0200
From:   "Arnd Bergmann" <arnd@...db.de>
To:     Köry Maincent <kory.maincent@...tlin.com>,
        "Krzysztof Kozlowski" <krzysztof.kozlowski@...aro.org>
Cc:     linux-arm-kernel@...ts.infradead.org, linux-kernel@...r.kernel.org,
        thomas.petazzoni@...tlin.com,
        "Russell King" <linux@...linux.org.uk>,
        "Gregory Clement" <gregory.clement@...tlin.com>,
        "Sudeep Holla" <sudeep.holla@....com>,
        "Alexandre Ghiti" <alexandre.ghiti@...onical.com>
Subject: Re: [PATCH 3/6] arm: configs: spear6xx: Enable PL110 display controller

On Wed, Oct 19, 2022, at 15:48, Köry Maincent wrote:
> Hello Krzysztof,
>
> On Wed, 19 Oct 2022 09:38:45 -0400
> Krzysztof Kozlowski <krzysztof.kozlowski@...aro.org> wrote:
>
>> On 19/10/2022 09:32, Köry Maincent wrote:
>> > From: Kory Maincent <kory.maincent@...tlin.com>
>> > 
>> > Enable the PL110 DRM driver, used by the spear600.
>> > 
>> > CONFIG_I2C is dropped from the defconfig as it is selected by CONFIG_DRM.  
>> 
>> I2C as a user-selectable option should stay. Don't remove such
>> (user-selectable) top-level options just because something else selected it.
>
> As the CONFIG_DRM selects it, the "make savedefconfig" removes it by default.
> Why keeping something that is already automatically enabled by CONFIG_DRM?

It's something that DRM probably should not select, so if this
ever gets fixed in DRM, you get a broken build. Just leaving
the line in there is harmless.

      Arnd