linux-kernel - Re: [PATCH V2] dmaengine: sprd: Support two-stage dma interrupt

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <Y1AEngC3y9+OyG5S@matsya>
Date:   Wed, 19 Oct 2022 19:37:26 +0530
From:   Vinod Koul <vkoul@...nel.org>
To:     Cixi Geng <gengcixi@...il.com>
Cc:     orsonzhai@...il.com, baolin.wang@...ux.alibaba.com,
        zhang.lyra@...il.com, dmaengine@...r.kernel.org,
        linux-kernel@...r.kernel.org, Cixi Geng <cixi.geng1@...soc.com>
Subject: Re: [PATCH V2] dmaengine: sprd: Support two-stage dma interrupt

On 04-10-22, 07:49, Cixi Geng wrote:
> From: Cixi Geng <cixi.geng1@...soc.com>
> 
> Audio need to request Audio CP global dma interrupt, so Audio CP
> DMA should support two-stage interrupt to adapte it.
> It will occur interrupt when two-stage dma channel transfer done.

The patch looks fine to me but...

> diff --git a/include/linux/dma/sprd-dma.h b/include/linux/dma/sprd-dma.h
> index d09c6f6f6da5..26de41d6d915 100644
> --- a/include/linux/dma/sprd-dma.h
> +++ b/include/linux/dma/sprd-dma.h

>  enum sprd_dma_int_type {
>  	SPRD_DMA_NO_INT,
> @@ -112,6 +120,10 @@ enum sprd_dma_int_type {
>  	SPRD_DMA_TRANS_BLK_INT,
>  	SPRD_DMA_LIST_INT,
>  	SPRD_DMA_CFGERR_INT,
> +	SPRD_DMA_SRC_CHN0_INT,
> +	SPRD_DMA_SRC_CHN1_INT,
> +	SPRD_DMA_DST_CHN0_INT,
> +	SPRD_DMA_DST_CHN1_INT,

why is sprd_dma_int_type part of driver interface. sprd_dma_int_type is
used only by this driver and should be moved into the driver..

Can you change that as well please

-- 
~Vinod