linux-kernel - Re: [PATCH] Microchip MCP795xx RTC driver patch

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <202210192335.vnDpLLo6-lkp@intel.com>
Date:   Wed, 19 Oct 2022 23:38:17 +0800
From:   kernel test robot <lkp@...el.com>
To:     tollsimy <simonetollardo@...il.com>, a.zummo@...ertech.it
Cc:     kbuild-all@...ts.01.org, alexandre.belloni@...tlin.com,
        linux-rtc@...r.kernel.org, linux-kernel@...r.kernel.org,
        tollsimy <simonetollardo@...il.com>
Subject: Re: [PATCH] Microchip MCP795xx RTC driver patch

Hi tollsimy,

Thank you for the patch! Perhaps something to improve:

[auto build test WARNING on abelloni/rtc-next]
[also build test WARNING on linus/master v6.1-rc1 next-20221019]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch#_base_tree_information]

url:    https://github.com/intel-lab-lkp/linux/commits/tollsimy/Microchip-MCP795xx-RTC-driver-patch/20221017-123625
base:   https://git.kernel.org/pub/scm/linux/kernel/git/abelloni/linux.git rtc-next
patch link:    https://lore.kernel.org/r/20221016162913.38661-1-simonetollardo%40gmail.com
patch subject: [PATCH] Microchip MCP795xx RTC driver patch
config: arc-randconfig-r043-20221017
compiler: arceb-elf-gcc (GCC) 12.1.0
reproduce (this is a W=1 build):
        wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
        chmod +x ~/bin/make.cross
        # https://github.com/intel-lab-lkp/linux/commit/cb64c8f9d220eaeef864af84eb164fa9440fe6da
        git remote add linux-review https://github.com/intel-lab-lkp/linux
        git fetch --no-tags linux-review tollsimy/Microchip-MCP795xx-RTC-driver-patch/20221017-123625
        git checkout cb64c8f9d220eaeef864af84eb164fa9440fe6da
        # save the config file
        mkdir build_dir && cp config build_dir/.config
        COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-12.1.0 make.cross W=1 O=build_dir ARCH=arc SHELL=/bin/bash drivers/gpio/ drivers/nvmem/ drivers/rtc/ kernel/events/

If you fix the issue, kindly add following tag where applicable
| Reported-by: kernel test robot <lkp@...el.com>

All warnings (new ones prefixed by >>):

   drivers/rtc/rtc-mcp795.c: In function 'mcp795_read_time':
>> drivers/rtc/rtc-mcp795.c:405:13: warning: variable 'tm_c_sec' set but not used [-Wunused-but-set-variable]
     405 |         int tm_c_sec;
         |             ^~~~~~~~


vim +/tm_c_sec +405 drivers/rtc/rtc-mcp795.c

   400	
   401	static int mcp795_read_time(struct device *dev, struct rtc_time *tim)
   402	{
   403		int ret;
   404		u8 data[8];
 > 405		int tm_c_sec;
   406	
   407		ret = mcp795_rtcc_read(dev, MCP795_REG_TMSECONDS, data, sizeof(data));
   408	
   409		if (ret)
   410			return ret;
   411	
   412		tm_c_sec	= bcd2bin(data[0] & 0xFF);
   413		tim->tm_sec	= bcd2bin(data[1] & 0x7F);
   414		tim->tm_min	= bcd2bin(data[2] & 0x7F);
   415		/* This is only for 24h mode, see datasheet for 12h mode */
   416		tim->tm_hour	= bcd2bin(data[3] & 0x3F);
   417		tim->tm_wday	= bcd2bin(data[4] & 0x07) - 1;
   418		tim->tm_mday	= bcd2bin(data[5] & 0x3F);
   419		tim->tm_mon	= bcd2bin(data[6] & 0x1F) - 1;
   420		tim->tm_year	= bcd2bin(data[7]);
   421	
   422		dev_dbg(dev, "Read from mcp795: %ptR\n", tim);
   423	
   424		return 0;
   425	}
   426	

-- 
0-DAY CI Kernel Test Service
https://01.org/lkp

View attachment "config" of type "text/plain" (137356 bytes)