linux-kernel - Re: [PATCH v2 2/2] dmaengine: qcom: gpi: Add compatible for QDU1000 and QRU1000

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <a4db0335-33d8-76cd-6f89-b8bde603aedf@quicinc.com>
Date:   Wed, 19 Oct 2022 10:08:16 -0700
From:   Melody Olvera <quic_molvera@...cinc.com>
To:     Vinod Koul <vkoul@...nel.org>,
        Krzysztof Kozlowski <krzysztof.kozlowski@...aro.org>
CC:     Andy Gross <agross@...nel.org>,
        Bjorn Andersson <andersson@...nel.org>,
        Rob Herring <robh+dt@...nel.org>,
        Krzysztof Kozlowski <krzysztof.kozlowski+dt@...aro.org>,
        <linux-arm-msm@...r.kernel.org>, <dmaengine@...r.kernel.org>,
        <devicetree@...r.kernel.org>, <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH v2 2/2] dmaengine: qcom: gpi: Add compatible for QDU1000
 and QRU1000



On 10/19/2022 6:30 AM, Vinod Koul wrote:
> On 15-10-22, 09:42, Krzysztof Kozlowski wrote:
>> On 14/10/2022 18:11, Melody Olvera wrote:
>>> Add compatible fields for the Qualcomm QDU1000 and QRU1000 SoCs.
>>>
>>> Signed-off-by: Melody Olvera <quic_molvera@...cinc.com>
>>> ---
>>>  drivers/dma/qcom/gpi.c | 2 ++
>>>  1 file changed, 2 insertions(+)
>>>
>>> diff --git a/drivers/dma/qcom/gpi.c b/drivers/dma/qcom/gpi.c
>>> index cc938a31dc2d..02438735e92b 100644
>>> --- a/drivers/dma/qcom/gpi.c
>>> +++ b/drivers/dma/qcom/gpi.c
>>> @@ -2286,6 +2286,8 @@ static int gpi_probe(struct platform_device *pdev)
>>>  }
>>>  
>>>  static const struct of_device_id gpi_of_match[] = {
>>> +	{ .compatible = "qcom,qdu1000-gpi-dma", .data = (void *)0x10000 },
>>> +	{ .compatible = "qcom,qru1000-gpi-dma", .data = (void *)0x10000 },
>> The feedback was: drop entire patch.
>>
>> There is really no need for this pattern to keep growing.
> Right, I have picked the patches so you dont need to add yours to driver
> file, please check dmaengine/next
>
Yes, I think I understand now; I'll just use existing compatibles and drop this PS.

Thanks,
Melody