linux-kernel - Re: [PATCH] rtc: rtc-cmos: Fix wake alarm breakage

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Wed, 19 Oct 2022 20:16:33 +0200
From:   Alexandre Belloni <alexandre.belloni@...tlin.com>
To:     "Rafael J. Wysocki" <rafael@...nel.org>
Cc:     "Rafael J. Wysocki" <rjw@...ysocki.net>,
        Mario Limonciello <mario.limonciello@....com>,
        Mel Gorman <mgorman@...hsingularity.net>,
        Zhang Rui <rui.zhang@...el.com>,
        LKML <linux-kernel@...r.kernel.org>,
        Todd Brandt <todd.e.brandt@...ux.intel.com>,
        Bjorn Helgaas <helgaas@...nel.org>,
        Linux ACPI <linux-acpi@...r.kernel.org>,
        Linux PM <linux-pm@...r.kernel.org>,
        Alessandro Zummo <a.zummo@...ertech.it>,
        linux-rtc@...r.kernel.org
Subject: Re: [PATCH] rtc: rtc-cmos: Fix wake alarm breakage

On 19/10/2022 18:13:43+0200, Rafael J. Wysocki wrote:
> On Tue, Oct 18, 2022 at 6:39 PM Alexandre Belloni
> <alexandre.belloni@...tlin.com> wrote:
> >
> > On Tue, 18 Oct 2022 18:09:31 +0200, Rafael J. Wysocki wrote:
> > > From: Rafael J. Wysocki <rafael.j.wysocki@...el.com>
> > >
> > > Commit 4919d3eb2ec0 ("rtc: cmos: Fix event handler registration
> > > ordering issue") overlooked the fact that cmos_do_probe() depended
> > > on the preparations carried out by cmos_wake_setup() and the wake
> > > alarm stopped working after the ordering of them had been changed.
> > >
> > > [...]
> >
> > Applied, thanks!
> >
> > [1/1] rtc: rtc-cmos: Fix wake alarm breakage
> >       commit: 0782b66ed2fbb035dda76111df0954515e417b24
> 
> Thank you!
> 
> However, there is a build fix on top of this which has just been posted:
> 
> https://lore.kernel.org/linux-acpi/2677035.mvXUDI8C0e@kreacher/
> 
> Sorry about breaking it again.

I had that in rtc-fixes:

https://git.kernel.org/pub/scm/linux/kernel/git/abelloni/linux.git/commit/?h=rtc-fixes


-- 
Alexandre Belloni, co-owner and COO, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com