linux-kernel - Re: [PATCH v2] i2c: Use u8 type in i2c transfer calls

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Wed, 19 Oct 2022 22:11:28 +0200
From:   Wolfram Sang <wsa-dev@...g-engineering.com>
To:     Jason Gerecke <killertofu@...il.com>
Cc:     Andy Shevchenko <andy.shevchenko@...il.com>,
        linux-i2c <linux-i2c@...r.kernel.org>,
        linux-iio <linux-iio@...r.kernel.org>,
        Jonathan Cameron <jic23@...nel.org>,
        Lars-Peter Clausen <lars@...afoo.de>,
        LKML <linux-kernel@...r.kernel.org>,
        Ping Cheng <pinglinux@...il.com>,
        "Tobita, Tatsunosuke" <tatsunosuke.tobita@...om.com>,
        Jason Gerecke <jason.gerecke@...om.com>,
        Ping Cheng <ping.cheng@...om.com>
Subject: Re: [PATCH v2] i2c: Use u8 type in i2c transfer calls


> > I believe you need to create a coccinelle script and run it over the
> > kernel source tree and then create a patch out of it.
> 
> This would definitely be necessary to unify all callers to using
> unsigned variables rather than just swapping which callers generate
> the pointer-sign warnings.

I am all for using u8 because this is the proper type.

Yet, if we touch this function argument, I'd also like to remove all
inconsistencies once and for all. Removing some warnings here and add
some there is not a good choice IMO. However, how to do this switch of
types cleanly without too much churn, I sadly have no good idea yet.


Download attachment "signature.asc" of type "application/pgp-signature" (834 bytes)