linux-kernel - Re: [PATCH 0/3] PCI/portdrv: Squash into portdrv.c

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <Y1BhrGziw+cet9Fm@kbusch-mbp.dhcp.thefacebook.com>
Date:   Wed, 19 Oct 2022 14:44:28 -0600
From:   Keith Busch <kbusch@...nel.org>
To:     Bjorn Helgaas <helgaas@...nel.org>
Cc:     linux-pci@...r.kernel.org, Stefan Roese <sr@...x.de>,
        Lukas Wunner <lukas@...ner.de>,
        Jan Kiszka <jan.kiszka@...mens.com>,
        Stuart Hayes <stuart.w.hayes@...il.com>,
        linux-kernel@...r.kernel.org, Bjorn Helgaas <bhelgaas@...gle.com>
Subject: Re: [PATCH 0/3] PCI/portdrv: Squash into portdrv.c

On Wed, Oct 19, 2022 at 03:41:24PM -0500, Bjorn Helgaas wrote:
> From: Bjorn Helgaas <bhelgaas@...gle.com>
> 
> The PCIe portdrv is split across portdrv_core.c and portdrv_pci.c, but
> neither is very big and it's a hassle to figure out which to look at.
> 
> Squash them into a single portdrv.c file.  Make functions static and
> non-exported when possible, and move some private things out of portdrv.h.

Looks like a nice cleanup.

Reviewed-by: Keith Busch <kbusch@...nel.org>