linux-kernel - Re: [ammarfaizi2-block:akpm/mm/mm-unstable 39/119] mm/memremap.c:521:6: warning: no previous prototype for 'zone_device_page

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20221019163202.500fd181836f47dce6bd81c1@linux-foundation.org>
Date:   Wed, 19 Oct 2022 16:32:02 -0700
From:   Andrew Morton <akpm@...ux-foundation.org>
To:     kernel test robot <lkp@...el.com>
Cc:     Dan Williams <dan.j.williams@...el.com>, kbuild-all@...ts.01.org,
        Ammar Faizi <ammarfaizi2@...weeb.org>,
        GNU/Weeb Mailing List <gwml@...r.gnuweeb.org>,
        linux-kernel@...r.kernel.org,
        Linux Memory Management List <linux-mm@...ck.org>
Subject: Re: [ammarfaizi2-block:akpm/mm/mm-unstable 39/119]
 mm/memremap.c:521:6: warning: no previous prototype for
 'zone_device_page_init'

On Wed, 19 Oct 2022 17:17:36 +0800 kernel test robot <lkp@...el.com> wrote:

> >> mm/memremap.c:521:6: warning: no previous prototype for 'zone_device_page_init' [-Wmissing-prototypes]
>      521 | void zone_device_page_init(struct page *page)
>          |      ^~~~~~~~~~~~~~~~~~~~~

huh, sorry, I must have fat-fingered the reject resolution on that one.

--- a/mm/memremap.c~mm-memremap_pages-replace-zone_device_page_init-with-pgmap_request_folios-fix
+++ a/mm/memremap.c
@@ -518,18 +518,6 @@ void free_zone_device_page(struct page *
 		put_dev_pagemap(page->pgmap);
 }
 
-void zone_device_page_init(struct page *page)
-{
-	/*
-	 * Drivers shouldn't be allocating pages after calling
-	 * memunmap_pages().
-	 */
-	WARN_ON_ONCE(!percpu_ref_tryget_live(&page->pgmap->ref));
-	set_page_count(page, 1);
-	lock_page(page);
-}
-EXPORT_SYMBOL_GPL(zone_device_page_init);
-
 static __maybe_unused bool folio_span_valid(struct dev_pagemap *pgmap,
 					    struct folio *folio,
 					    int nr_folios)
_