linux-kernel - Re: [PATCH v3] pwm: mtk-disp: Fix the parameters calculated by the enabled flag of disp

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20221019071954.qv67h3brj6vnhxpw@pengutronix.de>
Date:   Wed, 19 Oct 2022 09:19:54 +0200
From:   Uwe Kleine-König <u.kleine-koenig@...gutronix.de>
To:     xinlei.lee@...iatek.com
Cc:     thierry.reding@...il.com, matthias.bgg@...il.com,
        jitao.shi@...iatek.com, linux-pwm@...r.kernel.org,
        linux-arm-kernel@...ts.infradead.org,
        linux-mediatek@...ts.infradead.org, linux-kernel@...r.kernel.org,
        Project_Global_Chrome_Upstream_Group@...iatek.com
Subject: Re: [PATCH v3] pwm: mtk-disp: Fix the parameters calculated by the
 enabled flag of disp_pwm

Hello,

On Thu, Sep 29, 2022 at 06:26:49PM +0800, xinlei.lee@...iatek.com wrote:
> From: xinlei lee <xinlei.lee@...iatek.com>
> 
> In the original mtk_disp_pwm_get_state() function, the result of reading
> con0 & BIT(0) is enabled as disp_pwm.
> In order to conform to the register table, we should use the disp_pwm
> base address as the enabled judgment.

I assume the change is fine. However I don't understand the commit log.
My guess is you mean:

	mtk_disp_pwm_get_state() wrongly uses bit 0 of CON0 to judge if the
	PWM is enabled. However that is indicated by a bit (at a machine
	dependent position) in the DISP_PWM_EN register. Fix this
	accordingly.

> Fixes: 3f2b16734914 ("pwm: mtk-disp: Implement atomic API .get_state()")
> 
> Signed-off-by: xinlei lee <xinlei.lee@...iatek.com>

Nitpick: There is no empty line between Fixes: and S-o-b.

Best regards
Uwe

-- 
Pengutronix e.K.                           | Uwe Kleine-König            |
Industrial Linux Solutions                 | https://www.pengutronix.de/ |

Download attachment "signature.asc" of type "application/pgp-signature" (489 bytes)