linux-kernel - Re: [PATCH v4 4/6] blk-wbt: don't show valid wbt_lat

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Wed, 19 Oct 2022 09:06:12 +0800
From:   Yu Kuai <yukuai1@...weicloud.com>
To:     Christoph Hellwig <hch@...radead.org>,
        Yu Kuai <yukuai1@...weicloud.com>
Cc:     jack@...e.cz, ebiggers@...nel.org, paolo.valente@...aro.org,
        axboe@...nel.dk, linux-block@...r.kernel.org,
        linux-kernel@...r.kernel.org, yi.zhang@...wei.com,
        "yukuai (C)" <yukuai3@...wei.com>
Subject: Re: [PATCH v4 4/6] blk-wbt: don't show valid wbt_lat_usec in sysfs
 while wbt is disabled

Hi,

在 2022/10/18 23:49, Christoph Hellwig 写道:
>>   static ssize_t queue_wb_lat_show(struct request_queue *q, char *page)
>>   {
>> +	u64 lat;
>> +
>>   	if (!wbt_rq_qos(q))
>>   		return -EINVAL;
>>   
>> -	return sprintf(page, "%llu\n", div_u64(wbt_get_min_lat(q), 1000));
>> +	lat = wbt_disabled(q) ? 0 : div_u64(wbt_get_min_lat(q), 1000);
>> +
>> +	return sprintf(page, "%llu\n", lat);
> 
> 	if (wbt_disabled(q))
> 		return sprintf(page, "0\n");
> 	return sprintf(page, "%llu\n", div_u64(wbt_get_min_lat(q), 1000));
> 
> but otherwise the patch looks fine:
> 
> Reviewed-by: Christoph Hellwig <hch@....de>
> .
> 

Thanks for the review, I'll send a new version.

Kuai