linux-kernel - Re: [PATCH v2 0/2] perf: Fix "kernel lock contention analysis" test by not printing warnings in quiet mode

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <Y078hmAhP0oZivYc@kernel.org>
Date:   Tue, 18 Oct 2022 16:20:38 -0300
From:   Arnaldo Carvalho de Melo <acme@...nel.org>
To:     James Clark <james.clark@....com>
Cc:     linux-perf-users@...r.kernel.org, namhyung@...nel.org,
        linux-kernel@...r.kernel.org,
        Peter Zijlstra <peterz@...radead.org>,
        Ingo Molnar <mingo@...hat.com>,
        Mark Rutland <mark.rutland@....com>,
        Alexander Shishkin <alexander.shishkin@...ux.intel.com>,
        Jiri Olsa <jolsa@...nel.org>,
        Adrian Hunter <adrian.hunter@...el.com>,
        Ian Rogers <irogers@...gle.com>
Subject: Re: [PATCH v2 0/2] perf: Fix "kernel lock contention analysis" test
 by not printing warnings in quiet mode

Em Tue, Oct 18, 2022 at 10:41:34AM +0100, James Clark escreveu:
> This is V2, but the previous patch was titled 'perf: Fix "Track with
> sched_switch" test by not printing warnings in quiet mode'
> 
> Changes since V1:
> 
>   * Add a commit to make the behavior consistent between tools and
>     update the docs
>   * Fix the incorrect test name in the commit message

Namhyung, can I have your Acked-by, even you having some reservation
about this? You said that if this was the way forward, then
documentation should reflect that, which James did, so, wdyt?

- Arnaldo
 
> James Clark (2):
>   perf: Fix "kernel lock contention analysis" test by not printing
>     warnings in quiet mode
>   perf: Make quiet mode consistent between tools
> 
>  tools/perf/Documentation/perf-annotate.txt | 2 +-
>  tools/perf/Documentation/perf-diff.txt     | 2 +-
>  tools/perf/Documentation/perf-lock.txt     | 2 +-
>  tools/perf/Documentation/perf-probe.txt    | 2 +-
>  tools/perf/Documentation/perf-record.txt   | 2 +-
>  tools/perf/Documentation/perf-report.txt   | 2 +-
>  tools/perf/Documentation/perf-stat.txt     | 4 ++--
>  tools/perf/bench/numa.c                    | 9 +++++----
>  tools/perf/builtin-annotate.c              | 2 +-
>  tools/perf/builtin-diff.c                  | 2 +-
>  tools/perf/builtin-lock.c                  | 2 +-
>  tools/perf/builtin-probe.c                 | 7 +++----
>  tools/perf/builtin-record.c                | 2 +-
>  tools/perf/builtin-report.c                | 2 +-
>  tools/perf/builtin-stat.c                  | 8 ++++----
>  tools/perf/ui/util.c                       | 5 +++++
>  tools/perf/util/stat.h                     | 1 -
>  17 files changed, 30 insertions(+), 26 deletions(-)
> 
> -- 
> 2.28.0

-- 

- Arnaldo