linux-kernel - [PATCH] staging: pi433: Use div64_u64 instead of do

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [thread-next>] [day] [month] [year] [list]

Message-Id: <20221019094015.832398-1-tegongkang@gmail.com>
Date:   Wed, 19 Oct 2022 18:40:15 +0900
From:   Kang Minchul <tegongkang@...il.com>
To:     Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
        Paulo Miguel Almeida <paulo.miguel.almeida.rodenas@...il.com>
Cc:     Dan Carpenter <error27@...il.com>,
        Sidong Yang <realwakka@...il.com>,
        linux-staging@...ts.linux.dev, linux-kernel@...r.kernel.org,
        Kang Minchul <tegongkang@...il.com>
Subject: [PATCH] staging: pi433: Use div64_u64 instead of do_div

This commit removes warning generated by cocci as follows:

do_div() does a 64-by-32 division, please consider using div64_u64 instead.

Using div64_u64 instead of do_div can avoid potential truncation.

Signed-off-by: Kang Minchul <tegongkang@...il.com>
---
 drivers/staging/pi433/rf69.c | 8 ++++----
 1 file changed, 4 insertions(+), 4 deletions(-)

diff --git a/drivers/staging/pi433/rf69.c b/drivers/staging/pi433/rf69.c
index 8c7fab6a46bb..683dd94489f9 100644
--- a/drivers/staging/pi433/rf69.c
+++ b/drivers/staging/pi433/rf69.c
@@ -252,11 +252,11 @@ int rf69_set_deviation(struct spi_device *spi, u32 deviation)
 
 	// calculat f step
 	f_step = F_OSC * factor;
-	do_div(f_step, 524288); //  524288 = 2^19
+	div64_u64(f_step, 524288); //  524288 = 2^19
 
 	// calculate register settings
 	f_reg = deviation * factor;
-	do_div(f_reg, f_step);
+	div64_u64(f_reg, f_step);
 
 	msb = (f_reg & 0xff00) >> 8;
 	lsb = (f_reg & 0xff);
@@ -291,7 +291,7 @@ int rf69_set_frequency(struct spi_device *spi, u32 frequency)
 
 	// calculat f step
 	f_step = F_OSC * factor;
-	do_div(f_step, 524288); //  524288 = 2^19
+	div64_u64(f_step, 524288); //  524288 = 2^19
 
 	// check input value
 	f_max = div_u64(f_step * 8388608, factor);
@@ -302,7 +302,7 @@ int rf69_set_frequency(struct spi_device *spi, u32 frequency)
 
 	// calculate reg settings
 	f_reg = frequency * factor;
-	do_div(f_reg, f_step);
+	div64_u64(f_reg, f_step);
 
 	msb = (f_reg & 0xff0000) >> 16;
 	mid = (f_reg & 0xff00)   >>  8;
-- 
2.34.1