linux-kernel - Re: [PATCH v1] rcu: use hlist_nulls_next_rcu() in hlist_nulls_add_tail

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20221020184416.GV5600@paulmck-ThinkPad-P17-Gen-1>
Date:   Thu, 20 Oct 2022 11:44:16 -0700
From:   "Paul E. McKenney" <paulmck@...nel.org>
To:     zhaomzhao@....com
Cc:     frederic@...nel.org, quic_neeraju@...cinc.com,
        josh@...htriplett.org, rostedt@...dmis.org,
        mathieu.desnoyers@...icios.com, jiangshanlai@...il.com,
        joel@...lfernandes.org, edumazet@...gle.com, rcu@...r.kernel.org,
        linux-kernel@...r.kernel.org,
        Zhao Mengmeng <zhaomengmeng@...inos.cn>
Subject: Re: [PATCH v1] rcu: use hlist_nulls_next_rcu() in
 hlist_nulls_add_tail_rcu()

On Wed, Oct 19, 2022 at 08:36:50AM -0400, zhaomzhao@....com wrote:
> From: Zhao Mengmeng <zhaomengmeng@...inos.cn>
> 
> In commit 8dbd76e79a16 ("tcp/dccp: fix possible race
> __inet_lookup_established()"), function hlist_nulls_add_tail_rcu() was
> added back, but the local variable *last* is of type hlist_nulls_node,
> so use hlist_nulls_next_rcu() instead of hlist_next_rcu().
> 
> Signed-off-by: Zhao Mengmeng <zhaomengmeng@...inos.cn>

Good eyes!

I have queued this for testing and further review.

							Thanx, Paul

> ---
>  include/linux/rculist_nulls.h | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/include/linux/rculist_nulls.h b/include/linux/rculist_nulls.h
> index d8afdb8784c1..ba4c00dd8005 100644
> --- a/include/linux/rculist_nulls.h
> +++ b/include/linux/rculist_nulls.h
> @@ -139,7 +139,7 @@ static inline void hlist_nulls_add_tail_rcu(struct hlist_nulls_node *n,
>  	if (last) {
>  		n->next = last->next;
>  		n->pprev = &last->next;
> -		rcu_assign_pointer(hlist_next_rcu(last), n);
> +		rcu_assign_pointer(hlist_nulls_next_rcu(last), n);
>  	} else {
>  		hlist_nulls_add_head_rcu(n, h);
>  	}
> -- 
> 2.37.1
>