linux-kernel - Re: [PATCH] staging: r8188eu: replace IEs with ies

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <8617109bdc3e192b98e5c3b21ba871501a87f6d9.camel@perches.com>
Date:   Wed, 19 Oct 2022 21:35:32 -0700
From:   Joe Perches <joe@...ches.com>
To:     Jacob Bai <jacob.bai.au@...il.com>,
        Larry Finger <Larry.Finger@...inger.net>,
        Phillip Potter <phil@...lpotter.co.uk>,
        Pavel Skripkin <paskripkin@...il.com>,
        Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
        linux-staging@...ts.linux.dev, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] staging: r8188eu: replace IEs with ies

On Tue, 2022-10-18 at 21:54 +1100, Jacob Bai wrote:
> Replace wlan_bssid_ex struct member IEs to ies.
> CamelCase issue found by checkpatch.

Please try to avoid changing code merely to appease checkpatch.

What is the value of the last s?
When is a specific index of the IEs array actually used?

Mere renaming may be removing useful markings.

(removing a lot of the rename blocks)

> diff --git a/drivers/staging/r8188eu/include/wlan_bssdef.h b/drivers/staging/r8188eu/include/wlan_bssdef.h
[]
> @@ -239,7 +239,7 @@ struct wlan_bssid_ex {
>  	unsigned char SupportedRates[NDIS_802_11_LENGTH_RATES_EX];
>  	struct wlan_phy_info	PhyInfo;
>  	u32  IELength;
> -	u8  IEs[MAX_IE_SZ];	/* timestamp, beacon interval, and
> +	u8  ies[MAX_IE_SZ];	/* timestamp, beacon interval, and
>  				 * capability information) */
>  } __packed;
[]
> diff --git a/drivers/staging/r8188eu/os_dep/ioctl_linux.c b/drivers/staging/r8188eu/os_dep/ioctl_linux.c
[]
> @@ -104,11 +104,11 @@ static char *translate_scan(struct adapter *padapter,
>  
>  			if (pnetwork->network.Reserved[0] == 2) {/*  Probe Request */
>  				/*	Verifying the P2P IE */
> -				if (rtw_get_p2p_ie(pnetwork->network.IEs, pnetwork->network.IELength, NULL, &p2pielen))
> +				if (rtw_get_p2p_ie(pnetwork->network.ies, pnetwork->network.IELength, NULL, &p2pielen))
>  					blnGotP2PIE = true;
>  			} else {/*  Beacon or Probe Respones */
>  				/*	Verifying the P2P IE */
> -				if (rtw_get_p2p_ie(&pnetwork->network.IEs[12], pnetwork->network.IELength - 12, NULL, &p2pielen))
> +				if (rtw_get_p2p_ie(&pnetwork->network.ies[12], pnetwork->network.IELength - 12, NULL, &p2pielen))

For instance, these consistent 12 and "- 12" uses may be better as some
alternate array.

>  					blnGotP2PIE = true;
>  			}
>  		}
> @@ -131,7 +131,7 @@ static char *translate_scan(struct adapter *padapter,
>  	start = iwe_stream_add_point(info, start, stop, &iwe, pnetwork->network.Ssid.Ssid);
>  
>  	/* parsing HT_CAP_IE */
> -	p = rtw_get_ie(&pnetwork->network.IEs[12], _HT_CAPABILITY_IE_, &ht_ielen, pnetwork->network.IELength - 12);
> +	p = rtw_get_ie(&pnetwork->network.ies[12], _HT_CAPABILITY_IE_, &ht_ielen, pnetwork->network.IELength - 12);
>  
>  	if (p && ht_ielen > 0) {
>  		struct ieee80211_ht_cap *pht_capie;

etc...

Also this may be removing similarities between a few other realtek
staging drivers

$ git grep  "\[MAX_IE_SZ\]"
drivers/staging/r8188eu/include/wlan_bssdef.h:  u8  IEs[MAX_IE_SZ];     /* timestamp, beacon interval, and
drivers/staging/rtl8712/wlan_bssdef.h:  u8 IEs[MAX_IE_SZ];
drivers/staging/rtl8723bs/include/wlan_bssdef.h:        u8  ies[MAX_IE_SZ];     /* timestamp, beacon interval, and capability information) */