linux-kernel - Re: [PATCH -next] tty: hvc: make hvc_rtas

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <effb4a2a-2bdd-a4b7-f6db-948666515996@kernel.org>
Date:   Thu, 20 Oct 2022 07:29:26 +0200
From:   Jiri Slaby <jirislaby@...nel.org>
To:     ruanjinjie <ruanjinjie@...wei.com>, gregkh@...uxfoundation.org,
        linuxppc-dev@...ts.ozlabs.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH -next] tty: hvc: make hvc_rtas_dev static

On 19. 10. 22, 8:44, ruanjinjie wrote:
> The symbol is not used outside of the file, so mark it static.
> 
> Fixes the following warning:
> 
> drivers/tty/hvc/hvc_rtas.c:29:19: warning: symbol 'hvc_rtas_dev' was
> not declared. Should it be static?

Reviewed-by: Jiri Slaby <jirislaby@...nel.org>

> Signed-off-by: ruanjinjie <ruanjinjie@...wei.com>
> ---
>   drivers/tty/hvc/hvc_rtas.c | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/tty/hvc/hvc_rtas.c b/drivers/tty/hvc/hvc_rtas.c
> index e8b8c645482b..184d325abeed 100644
> --- a/drivers/tty/hvc/hvc_rtas.c
> +++ b/drivers/tty/hvc/hvc_rtas.c
> @@ -26,7 +26,7 @@
>   #include "hvc_console.h"
>   
>   #define hvc_rtas_cookie 0x67781e15
> -struct hvc_struct *hvc_rtas_dev;
> +static struct hvc_struct *hvc_rtas_dev;
>   
>   static int rtascons_put_char_token = RTAS_UNKNOWN_SERVICE;
>   static int rtascons_get_char_token = RTAS_UNKNOWN_SERVICE;

-- 
js
suse labs