linux-kernel - Re: [PATCH] staging: rts5208: Replace instances of udelay by usleep

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CAHJEyKXnSdgzGVaFX6ayU3DusETOLZRcpKJJ9ZO_76ofbBTacA@mail.gmail.com>
Date:   Thu, 20 Oct 2022 07:08:18 +0100
From:   Tanju Brunostar <tanjubrunostar0@...il.com>
To:     Joe Perches <joe@...ches.com>
Cc:     gregkh@...uxfoundation.org, linux-staging@...ts.linux.dev,
        linux-kernel@...r.kernel.org, outreachy@...ts.linux.dev
Subject: Re: [PATCH] staging: rts5208: Replace instances of udelay by usleep_range

On Thu, Oct 20, 2022 at 5:40 AM Joe Perches <joe@...ches.com> wrote:
>
> On Tue, 2022-10-18 at 14:04 +0000, Tanjuate Brunostar wrote:
> > Replace the use of udelay by usleep_range as suggested by checkpatch:
> >
> > CHECK: usleep_range is preferred over udelay; see Documentation/timers/timers-howto.rst
> > +               udelay(30);
> []
> > diff --git a/drivers/staging/rts5208/ms.c b/drivers/staging/rts5208/ms.c
> []
> > @@ -3235,7 +3235,7 @@ static int ms_write_multiple_pages(struct rtsx_chip *chip, u16 old_blk,
> >                       return STATUS_FAIL;
> >               }
> >
> > -             udelay(30);
> > +             usleep_range(30, 30);
>
> >This isn't useful.  Please read the Documentation/timers.

Yes I read the documentation and realized the changes were not necessary