lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Thu, 20 Oct 2022 14:33:16 +0800 From: Fenglin Wu <quic_fenglinw@...cinc.com> To: Krzysztof Kozlowski <krzysztof.kozlowski@...aro.org>, <linux-arm-msm@...r.kernel.org>, <linux-kernel@...r.kernel.org>, Andy Gross <agross@...nel.org>, Bjorn Andersson <bjorn.andersson@...aro.org>, "Konrad Dybcio" <konrad.dybcio@...ainline.org>, Pavel Machek <pavel@....cz>, "Rob Herring" <robh+dt@...nel.org>, Krzysztof Kozlowski <krzysztof.kozlowski+dt@...aro.org>, <linux-leds@...r.kernel.org>, <devicetree@...r.kernel.org> CC: <quic_collinsd@...cinc.com>, <quic_subbaram@...cinc.com> Subject: Re: [PATCH v3 2/2] dt-bindings: add bindings for QCOM flash LED On 2022/10/19 21:36, Krzysztof Kozlowski wrote: > On 17/10/2022 21:40, Fenglin Wu wrote: >> Add binding document for flash LED module inside Qualcomm Technologies, >> Inc. PMICs. > > Use subject prefixes matching the subsystem (git log --oneline -- ...). > > This means: > 1. you miss subsystem prefix > 2. drop redundant second "bindings" > >> >> Signed-off-by: Fenglin Wu <quic_fenglinw@...cinc.com> >> --- >> .../bindings/leds/qcom,spmi-flash-led.yaml | 116 ++++++++++++++++++ >> 1 file changed, 116 insertions(+) >> create mode 100644 Documentation/devicetree/bindings/leds/qcom,spmi-flash-led.yaml >> >> diff --git a/Documentation/devicetree/bindings/leds/qcom,spmi-flash-led.yaml b/Documentation/devicetree/bindings/leds/qcom,spmi-flash-led.yaml >> new file mode 100644 >> index 000000000000..d8efde02db72 >> --- /dev/null >> +++ b/Documentation/devicetree/bindings/leds/qcom,spmi-flash-led.yaml >> @@ -0,0 +1,116 @@ >> +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause) >> +%YAML 1.2 >> +--- >> +$id: http://devicetree.org/schemas/leds/qcom,spmi-flash-led.yaml# >> +$schema: http://devicetree.org/meta-schemas/core.yaml# >> + >> +title: Flash LED device inside Qualcomm Technologies, Inc. PMICs >> + >> +maintainers: >> + - Fenglin Wu <quic_fenglinw@...cinc.com> >> + >> +description: | >> + Flash LED controller is present inside some Qualcomm Technologies, Inc. PMICs. >> + The flash LED module can have different number of LED channels supported >> + e.g. 3 or 4. There are some different registers between them but they can >> + both support maximum current up to 1.5 A per channel and they can also support >> + ganging 2 channels together to supply maximum current up to 2 A. The current >> + will be split symmetrically on each channel and they will be enabled and >> + disabled at the same time. >> + >> +properties: >> + compatible: >> + items: >> + - enum: >> + - qcom,pm8150c-flash-led >> + - qcom,pm8150l-flash-led >> + - qcom,pm8350c-flash-led >> + - const: qcom,spmi-flash-led > > Blank line > >> + reg: >> + description: address offset of the flash LED controller > > Drop description, it's obvious. > >> + maxItems: 1 >> + >> +patternProperties: >> + "^led-[0-3]$": >> + type: object >> + $ref: common.yaml# >> + unevaluatedProperties: false >> + description: | > > No need for | > >> + Represents the physical LED components which are connected to the >> + flash LED channels' output. >> + >> + properties: >> + led-sources: >> + description: | > > No need for | > > Rest looks good: > > Reviewed-by: Krzysztof Kozlowski <krzysztof.kozlowski@...aro.org> > > Best regards, > Krzysztof > Thanks you Krzysztof! I will address them when pushing next patch.
Powered by blists - more mailing lists