linux-kernel - Re: [PATCH 31/33] dmaengine: at_hdmac: Use pm

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <cbdf8ee5-ee73-82b2-a12c-5c66312e804a@microchip.com>
Date:   Thu, 20 Oct 2022 07:10:16 +0000
From:   <Tudor.Ambarus@...rochip.com>
To:     <vkoul@...nel.org>
CC:     <peda@...ntia.se>, <du@...ntia.se>, <regressions@...mhuis.info>,
        <Ludovic.Desroches@...rochip.com>, <maciej.sosnowski@...el.com>,
        <dan.j.williams@...el.com>, <Nicolas.Ferre@...rochip.com>,
        <mripard@...nel.org>, <torfl6749@...il.com>,
        <linux-kernel@...r.kernel.org>, <dmaengine@...r.kernel.org>,
        <linux-arm-kernel@...ts.infradead.org>, <tudor.ambarus@...il.com>
Subject: Re: [PATCH 31/33] dmaengine: at_hdmac: Use pm_ptr()

On 10/19/22 19:50, Vinod Koul wrote:
> EXTERNAL EMAIL: Do not click links or open attachments unless you know the content is safe
> 
> On 20-08-22, 15:57, Tudor Ambarus wrote:
>> From: Tudor Ambarus <tudor.ambarus@...il.com>
>>
>> Use pm_ptr() macro to fill at_xdmac_driver.driver.pm. In case CONFIG_PM is
>> not enabled, the macro will return NULL.
> 
> You annotated at_dma_dev_pm_ops with __maybe_unused which is a correct
> thing to do, but should be explained here

okay, will refine the commit message.

> 
>>
>> Signed-off-by: Tudor Ambarus <tudor.ambarus@...il.com>
>> ---
>>  drivers/dma/at_hdmac.c | 4 ++--
>>  1 file changed, 2 insertions(+), 2 deletions(-)
>>
>> diff --git a/drivers/dma/at_hdmac.c b/drivers/dma/at_hdmac.c
>> index 0b473e6d161d..e35b4b325452 100644
>> --- a/drivers/dma/at_hdmac.c
>> +++ b/drivers/dma/at_hdmac.c
>> @@ -2524,7 +2524,7 @@ static int at_dma_resume_noirq(struct device *dev)
>>       return 0;
>>  }
>>
>> -static const struct dev_pm_ops at_dma_dev_pm_ops = {
>> +static const struct dev_pm_ops __maybe_unused at_dma_dev_pm_ops = {
>>       .prepare = at_dma_prepare,
>>       .suspend_noirq = at_dma_suspend_noirq,
>>       .resume_noirq = at_dma_resume_noirq,
>> @@ -2536,7 +2536,7 @@ static struct platform_driver at_dma_driver = {
>>       .id_table       = atdma_devtypes,
>>       .driver = {
>>               .name   = "at_hdmac",
>> -             .pm     = &at_dma_dev_pm_ops,
>> +             .pm     = pm_ptr(&at_dma_dev_pm_ops),
>>               .of_match_table = of_match_ptr(atmel_dma_dt_ids),
>>       },
>>  };
>> --
>> 2.25.1
> 
> --
> ~Vinod

-- 
Cheers,
ta