linux-kernel - Re: [PATCH v3 2/2] spi: meson-spicc: Use pinctrl to drive CLK line when idle

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <a6942e7a-faa5-d839-aebf-0d28e7e14f06@linaro.org>
Date:   Thu, 20 Oct 2022 10:18:18 +0200
From:   Neil Armstrong <neil.armstrong@...aro.org>
To:     Martin Blumenstingl <martin.blumenstingl@...glemail.com>,
        Amjad Ouled-Ameur <aouledameur@...libre.com>
Cc:     Mark Brown <broonie@...nel.org>,
        Krzysztof Kozlowski <krzysztof.kozlowski+dt@...aro.org>,
        Jerome Brunet <jbrunet@...libre.com>,
        Kevin Hilman <khilman@...libre.com>,
        Rob Herring <robh+dt@...nel.org>, Da Xue <da@...re.computer>,
        linux-arm-kernel@...ts.infradead.org, devicetree@...r.kernel.org,
        linux-amlogic@...ts.infradead.org, linux-spi@...r.kernel.org,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH v3 2/2] spi: meson-spicc: Use pinctrl to drive CLK line
 when idle

On 19/10/2022 22:50, Martin Blumenstingl wrote:
> Hi Amjad,
> 
> On Wed, Oct 19, 2022 at 4:03 PM Amjad Ouled-Ameur
> <aouledameur@...libre.com> wrote:
> [...]
>> diff --git a/arch/arm64/boot/dts/amlogic/meson-gxl.dtsi b/arch/arm64/boot/dts/amlogic/meson-gxl.dtsi
>> index c3ac531c4f84..04e9d0f1bde0 100644
>> --- a/arch/arm64/boot/dts/amlogic/meson-gxl.dtsi
>> +++ b/arch/arm64/boot/dts/amlogic/meson-gxl.dtsi
>> @@ -429,6 +429,20 @@ mux {
>>                          };
>>                  };
>>
>> +               spi_idle_high_pins: spi-idle-high-pins {
>> +                       mux {
>> +                               groups = "spi_sclk";
>> +                               bias-pull-up;
>> +                       };
>> +               };
>> +
>> +               spi_idle_low_pins: spi-idle-low-pins {
>> +                       mux {
>> +                               groups = "spi_sclk";
>> +                               bias-pull-down;
>> +                       };
>> +               };
>> +
> We typically have the .dts{,i} changes in a separate patch. I suggest
> doing the same here.
> I also have two questions about this part:
> - why are these not referenced by the SPICC controller node?

Because it's up to the board to use or not those states, if some pull-up/downs
are already present on the lines no need to use those special states.

> - is there a particular reason why meson-gxl.dtsi is updated but
> meson-gxbb.dtsi is not? (my understanding is that GXBB is also lacking
> hardware OEN support)

Good question indeed, so indeed they should be added in meson-gxbb.dtsi in a separate patch.
> 
> 
> Best regards,
> Martin

Thanks,
Neil