lists.openwall.net   lists  /  announce  owl-users  owl-dev  john-users  john-dev  passwdqc-users  yescrypt  popa3d-users  /  oss-security  kernel-hardening  musl  sabotage  tlsify  passwords  /  crypt-dev  xvendor  /  Bugtraq  Full-Disclosure  linux-kernel  linux-netdev  linux-ext4  linux-hardening  linux-cve-announce  PHC 
Open Source and information security mailing list archives
 
Hash Suite: Windows password security audit tool. GUI, reports in PDF.
[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Date:   Thu, 20 Oct 2022 16:39:56 +0800
From:   kernel test robot <lkp@...el.com>
To:     "Jason A. Donenfeld" <Jason@...c4.com>,
        linux-kernel@...r.kernel.org, linux-kbuild@...r.kernel.org,
        linux-arch@...r.kernel.org, linux-toolchains@...r.kernel.org
Cc:     kbuild-all@...ts.01.org, "Jason A. Donenfeld" <Jason@...c4.com>,
        Masahiro Yamada <masahiroy@...nel.org>,
        Kees Cook <keescook@...omium.org>,
        Andrew Morton <akpm@...ux-foundation.org>,
        Linux Memory Management List <linux-mm@...ck.org>,
        Andy Shevchenko <andriy.shevchenko@...ux.intel.com>,
        Greg Kroah-Hartman <gregkh@...uxfoundation.org>
Subject: Re: [PATCH] kbuild: treat char as always signed

Hi Jason,

I love your patch! Perhaps something to improve:

[auto build test WARNING on masahiroy-kbuild/for-next]
[also build test WARNING on linus/master v6.1-rc1]
[cannot apply to next-20221020]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch#_base_tree_information]

url:    https://github.com/intel-lab-lkp/linux/commits/Jason-A-Donenfeld/kbuild-treat-char-as-always-signed/20221020-113408
base:   https://git.kernel.org/pub/scm/linux/kernel/git/masahiroy/linux-kbuild.git for-next
patch link:    https://lore.kernel.org/r/20221019162648.3557490-1-Jason%40zx2c4.com
patch subject: [PATCH] kbuild: treat char as always signed
config: s390-allmodconfig
compiler: s390-linux-gcc (GCC) 12.1.0
reproduce (this is a W=1 build):
        wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
        chmod +x ~/bin/make.cross
        # https://github.com/intel-lab-lkp/linux/commit/574c38568c2c4a092070a42616218871cf6b7ff9
        git remote add linux-review https://github.com/intel-lab-lkp/linux
        git fetch --no-tags linux-review Jason-A-Donenfeld/kbuild-treat-char-as-always-signed/20221020-113408
        git checkout 574c38568c2c4a092070a42616218871cf6b7ff9
        # save the config file
        mkdir build_dir && cp config build_dir/.config
        COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-12.1.0 make.cross W=1 O=build_dir ARCH=s390 SHELL=/bin/bash drivers/s390/block/ drivers/s390/char/

If you fix the issue, kindly add following tag where applicable
| Reported-by: kernel test robot <lkp@...el.com>

All warnings (new ones prefixed by >>):

   drivers/s390/block/dasd.c: In function '__dasd_process_cqr':
>> drivers/s390/block/dasd.c:1912:9: warning: case label value exceeds maximum value for type [-Wswitch-outside-range]
    1912 |         case DASD_CQR_ERROR:
         |         ^~~~
   drivers/s390/block/dasd.c:1915:9: warning: case label value exceeds maximum value for type [-Wswitch-outside-range]
    1915 |         case DASD_CQR_CLEARED:
         |         ^~~~
   drivers/s390/block/dasd.c:1909:9: warning: case label value exceeds maximum value for type [-Wswitch-outside-range]
    1909 |         case DASD_CQR_SUCCESS:
         |         ^~~~
   drivers/s390/block/dasd.c: In function 'dasd_flush_device_queue':
   drivers/s390/block/dasd.c:2113:17: warning: case label value exceeds maximum value for type [-Wswitch-outside-range]
    2113 |                 case DASD_CQR_QUEUED:
         |                 ^~~~
   drivers/s390/block/dasd.c:2102:17: warning: case label value exceeds maximum value for type [-Wswitch-outside-range]
    2102 |                 case DASD_CQR_IN_IO:
         |                 ^~~~
   drivers/s390/block/dasd.c: In function '__dasd_cancel_req':
   drivers/s390/block/dasd.c:2615:9: warning: case label value exceeds maximum value for type [-Wswitch-outside-range]
    2615 |         case DASD_CQR_QUEUED:
         |         ^~~~
   drivers/s390/block/dasd.c:2619:9: warning: case label value exceeds maximum value for type [-Wswitch-outside-range]
    2619 |         case DASD_CQR_IN_IO:
         |         ^~~~
--
   drivers/s390/block/dasd_3990_erp.c: In function 'dasd_3990_handle_env_data':
>> drivers/s390/block/dasd_3990_erp.c:861:9: warning: case label value exceeds maximum value for type [-Wswitch-outside-range]
     861 |         case 0x80:  /* Format 8 - Additional Device Equipment Checks */
         |         ^~~~
   drivers/s390/block/dasd_3990_erp.c:914:9: warning: case label value exceeds maximum value for type [-Wswitch-outside-range]
     914 |         case 0x90:  /* Format 9 - Device Read, Write, and Seek Checks */
         |         ^~~~
   drivers/s390/block/dasd_3990_erp.c:943:9: warning: case label value exceeds maximum value for type [-Wswitch-outside-range]
     943 |         case 0xF0:              /* Format F - Cache Storage Checks */
         |         ^~~~
--
   drivers/s390/char/sclp_vt220.c: In function 'sclp_vt220_receiver_fn':
>> drivers/s390/char/sclp_vt220.c:536:9: warning: case label value exceeds maximum value for type [-Wswitch-outside-range]
     536 |         case SCLP_VT220_SESSION_STARTED:
         |         ^~~~


vim +1912 drivers/s390/block/dasd.c

^1da177e4c3f41 Linus Torvalds     2005-04-16  1902  
5c618c0cf451f1 Sebastian Ott      2018-05-24  1903  static void __dasd_process_cqr(struct dasd_device *device,
5c618c0cf451f1 Sebastian Ott      2018-05-24  1904  			       struct dasd_ccw_req *cqr)
^1da177e4c3f41 Linus Torvalds     2005-04-16  1905  {
fc19f381b3828a Stefan Haberland   2009-03-26  1906  	char errorstring[ERRORLENGTH];
f24acd4503270e Horst Hummel       2005-05-01  1907  
8e09f21574ea30 Stefan Weinhuber   2008-01-26  1908  	switch (cqr->status) {
8e09f21574ea30 Stefan Weinhuber   2008-01-26  1909  	case DASD_CQR_SUCCESS:
8e09f21574ea30 Stefan Weinhuber   2008-01-26  1910  		cqr->status = DASD_CQR_DONE;
d54853ef8cb172 Martin Schwidefsky 2007-02-05  1911  		break;
8e09f21574ea30 Stefan Weinhuber   2008-01-26 @1912  	case DASD_CQR_ERROR:
8e09f21574ea30 Stefan Weinhuber   2008-01-26  1913  		cqr->status = DASD_CQR_NEED_ERP;
d54853ef8cb172 Martin Schwidefsky 2007-02-05  1914  		break;
8e09f21574ea30 Stefan Weinhuber   2008-01-26  1915  	case DASD_CQR_CLEARED:
8e09f21574ea30 Stefan Weinhuber   2008-01-26  1916  		cqr->status = DASD_CQR_TERMINATED;
8e09f21574ea30 Stefan Weinhuber   2008-01-26  1917  		break;
8e09f21574ea30 Stefan Weinhuber   2008-01-26  1918  	default:
fc19f381b3828a Stefan Haberland   2009-03-26  1919  		/* internal error 12 - wrong cqr status*/
fc19f381b3828a Stefan Haberland   2009-03-26  1920  		snprintf(errorstring, ERRORLENGTH, "12 %p %x02", cqr, cqr->status);
fc19f381b3828a Stefan Haberland   2009-03-26  1921  		dev_err(&device->cdev->dev,
fc19f381b3828a Stefan Haberland   2009-03-26  1922  			"An error occurred in the DASD device driver, "
fc19f381b3828a Stefan Haberland   2009-03-26  1923  			"reason=%s\n", errorstring);
8e09f21574ea30 Stefan Weinhuber   2008-01-26  1924  		BUG();
d54853ef8cb172 Martin Schwidefsky 2007-02-05  1925  	}
5c618c0cf451f1 Sebastian Ott      2018-05-24  1926  	if (cqr->callback)
5c618c0cf451f1 Sebastian Ott      2018-05-24  1927  		cqr->callback(cqr, cqr->callback_data);
5c618c0cf451f1 Sebastian Ott      2018-05-24  1928  }
5c618c0cf451f1 Sebastian Ott      2018-05-24  1929  

-- 
0-DAY CI Kernel Test Service
https://01.org/lkp

View attachment "config" of type "text/plain" (120832 bytes)

Powered by blists - more mailing lists

Powered by Openwall GNU/*/Linux Powered by OpenVZ