linux-kernel - Re: [PATCH v3] wifi: rt2x00: use explicitly signed or unsigned types

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Thu, 20 Oct 2022 12:29:20 +0200
From:   Stanislaw Gruszka <stf_xl@...pl>
To:     "Jason A. Donenfeld" <Jason@...c4.com>
Cc:     linux-wireless@...r.kernel.org, netdev@...r.kernel.org,
        linux-kernel@...r.kernel.org,
        Andrew Morton <akpm@...ux-foundation.org>,
        Andy Shevchenko <andriy.shevchenko@...ux.intel.com>,
        Helmut Schaa <helmut.schaa@...glemail.com>,
        Kalle Valo <kvalo@...nel.org>
Subject: Re: [PATCH v3] wifi: rt2x00: use explicitly signed or unsigned types

On Wed, Oct 19, 2022 at 09:55:41AM -0600, Jason A. Donenfeld wrote:
> On some platforms, `char` is unsigned, but this driver, for the most
> part, assumed it was signed. In other places, it uses `char` to mean an
> unsigned number, but only in cases when the values are small. And in
> still other places, `char` is used as a boolean. Put an end to this
> confusion by declaring explicit types, depending on the context.
> 
> Cc: Andrew Morton <akpm@...ux-foundation.org>
> Cc: Andy Shevchenko <andriy.shevchenko@...ux.intel.com>
> Cc: Stanislaw Gruszka <stf_xl@...pl>
> Cc: Helmut Schaa <helmut.schaa@...glemail.com>
> Cc: Kalle Valo <kvalo@...nel.org>
> Signed-off-by: Jason A. Donenfeld <Jason@...c4.com>

Acked-by: Stanislaw Gruszka <stf_xl@...pl>