linux-kernel - Re: [PATCH v3] staging: vt6655: Fix Lines should not end with a '('

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Thu, 20 Oct 2022 13:10:56 +0200
From:   Nam Cao <namcaov@...il.com>
To:     Tanjuate Brunostar <tanjubrunostar0@...il.com>
Cc:     outreachy@...ts.linux.dev, greg@...ah.com,
        forest@...ttletooquiet.net, linux-staging@...ts.linux.dev,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH v3] staging: vt6655: Fix Lines should not end with a '('

On Thu, Oct 20, 2022 at 10:56:33AM +0000, Tanjuate Brunostar wrote:
> Code style warnings reported by checkpatch.
> Improve the layout of a function header:
> Put the first parameter immediately after the '(' and align the other
> parameters underneath it.
> 
> Signed-off-by: Tanjuate Brunostar <tanjubrunostar0@...il.com>
> 
> ---
> v2: put static and void on the same line and adjusted the indentation as
> suggested by Greg KH
> ---
>  drivers/staging/vt6655/rxtx.c | 18 ++++++------------
>  1 file changed, 6 insertions(+), 12 deletions(-)
> 
> diff --git a/drivers/staging/vt6655/rxtx.c b/drivers/staging/vt6655/rxtx.c
> index 5bdb5176772c..d987f7dff02a 100644
> --- a/drivers/staging/vt6655/rxtx.c
> +++ b/drivers/staging/vt6655/rxtx.c
> @@ -85,10 +85,8 @@ static const unsigned short wFB_Opt1[2][5] = {
>  #define DATADUR_A_F1    13
>  
>  /*---------------------  Static Functions  --------------------------*/
> -static
> -void
> -s_vFillRTSHead(
> -	struct vnt_private *pDevice,
> +static void
> +s_vFillRTSHead(struct vnt_private *pDevice,
>  	unsigned char byPktType,
>  	void *pvRTS,
>  	unsigned int	cbFrameLength,
> @@ -96,13 +94,10 @@ s_vFillRTSHead(
>  	bool bDisCRC,
>  	struct ieee80211_hdr *hdr,
>  	unsigned short wCurrentRate,
> -	unsigned char byFBOption
> -);
> +	unsigned char byFBOption);
>  
> -static
> -void
> -s_vGenerateTxParameter(
> -	struct vnt_private *pDevice,
> +static void
> +s_vGenerateTxParameter(struct vnt_private *pDevice,
>  	unsigned char byPktType,
>  	struct vnt_tx_fifo_head *,
>  	void *pvRrvTime,
> @@ -112,8 +107,7 @@ s_vGenerateTxParameter(
>  	bool bNeedACK,
>  	unsigned int	uDMAIdx,
>  	void *psEthHeader,
> -	unsigned short wCurrentRate
> -);
> +	unsigned short wCurrentRate);
>  
>  static unsigned int
>  s_cbFillTxBufHead(struct vnt_private *pDevice, unsigned char byPktType,
> -- 
> 2.34.1
>

I think you mistakenly sent v2 again..

Best regards,
Nam