linux-kernel - Re: [PATCH V2] dmaengine: sprd: Support two-stage dma interrupt

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <Y1EvX+hL/LWBnuvX@matsya>
Date:   Thu, 20 Oct 2022 16:52:07 +0530
From:   Vinod Koul <vkoul@...nel.org>
To:     Baolin Wang <baolin.wang@...ux.alibaba.com>
Cc:     Cixi Geng <gengcixi@...il.com>, orsonzhai@...il.com,
        zhang.lyra@...il.com, dmaengine@...r.kernel.org,
        linux-kernel@...r.kernel.org, Cixi Geng <cixi.geng1@...soc.com>
Subject: Re: [PATCH V2] dmaengine: sprd: Support two-stage dma interrupt

On 20-10-22, 16:15, Baolin Wang wrote:

> > > why is sprd_dma_int_type part of driver interface. sprd_dma_int_type is
> > > used only by this driver and should be moved into the driver..
> 
> Now we can not move this into dma driver, since we have some drivers in the
> mainline will set the DMA interrupt type, such as spi-sprd.c, sprd_serial.c
> and sprd-pcm-compress.c.

That may not sound right.. Why should peripheral set the DMA
interrupt..?

-- 
~Vinod