linux-kernel - Re: [PATCH v2 5/7] mm: vmalloc: Use trace_purge_vmap_area

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <Y1EwEg7E4OodgecC@infradead.org>
Date:   Thu, 20 Oct 2022 04:25:06 -0700
From:   Christoph Hellwig <hch@...radead.org>
To:     "Uladzislau Rezki (Sony)" <urezki@...il.com>
Cc:     Andrew Morton <akpm@...ux-foundation.org>, linux-mm@...ck.org,
        LKML <linux-kernel@...r.kernel.org>,
        Christoph Hellwig <hch@...radead.org>,
        Matthew Wilcox <willy@...radead.org>,
        Nicholas Piggin <npiggin@...il.com>,
        Steven Rostedt <rostedt@...dmis.org>,
        Oleksiy Avramchenko <oleksiy.avramchenko@...y.com>
Subject: Re: [PATCH v2 5/7] mm: vmalloc: Use trace_purge_vmap_area_lazy event

> +	return num_purged_areas > 0 ? true:false;

The formatting here is a bit off due to the lack of whitespaces around
the :.  But as boolean expression propagate to boolean values this
can be simplified to:

	return num_purged_areas > 0;

anyway.

Otherwise looks good:

Reviewed-by: Christoph Hellwig <hch@....de>