linux-kernel - [PATCH] edac: fix period calculation in edac_device_reset_delay

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [day] [month] [year] [list]

Message-ID: <20221020114203.10985-1-farbere@amazon.com>
Date:   Thu, 20 Oct 2022 11:42:03 +0000
From:   Eliav Farber <farbere@...zon.com>
To:     <bp@...en8.de>, <mchehab@...nel.org>, <tony.luck@...el.com>,
        <james.morse@....com>, <rric@...nel.org>,
        <linux-edac@...r.kernel.org>, <linux-kernel@...r.kernel.org>
CC:     <talel@...zon.com>, <jonnyc@...zon.com>, <hhhawa@...zon.com>,
        <hanochu@...zon.com>, <farbere@...zon.com>, <itamark@...zon.com>,
        <shellykz@...zon.com>, <amitlavi@...zon.com>, <dkl@...zon.com>
Subject: [PATCH] edac: fix period calculation in edac_device_reset_delay_period()

Fix period calculation in case user sets a value of 1000.
The input of round_jiffies_relative() should be in jiffies and not in
milli-seconds.

Signed-off-by: Eliav Farber <farbere@...zon.com>
---
 drivers/edac/edac_device.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/edac/edac_device.c b/drivers/edac/edac_device.c
index 19522c568aa5..88942a6edc2c 100644
--- a/drivers/edac/edac_device.c
+++ b/drivers/edac/edac_device.c
@@ -399,7 +399,7 @@ void edac_device_reset_delay_period(struct edac_device_ctl_info *edac_dev,
 	unsigned long jiffs = msecs_to_jiffies(value);
 
 	if (value == 1000)
-		jiffs = round_jiffies_relative(value);
+		jiffs = round_jiffies_relative(jiffs);
 
 	edac_dev->poll_msec = value;
 	edac_dev->delay	    = jiffs;
-- 
2.37.1