linux-kernel - Re: [PATCH] of: fix repeated words in comments

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Wed, 19 Oct 2022 21:39:36 -0400
From:   "Theodore Ts'o" <tytso@....edu>
To:     Randy Dunlap <rdunlap@...radead.org>
Cc:     Jilin Yuan <yuanjilin@...rlc.com>, robh+dt@...nel.org,
        frowand.list@...il.com, devicetree@...r.kernel.org,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH] of: fix repeated words in comments

On Wed, Oct 19, 2022 at 11:53:54AM -0700, Randy Dunlap wrote:
> 
> On 10/19/22 06:02, Jilin Yuan wrote:
> > Delete the redundant word 'of'.
> > 
> > Signed-off-by: Jilin Yuan <yuanjilin@...rlc.com>
> > ---
> >  drivers/of/device.c | 2 +-
> >  1 file changed, 1 insertion(+), 1 deletion(-)
> > 
> > diff --git a/drivers/of/device.c b/drivers/of/device.c
> > index 8cefe5a7d04e..16c7e5a2a868 100644
> > --- a/drivers/of/device.c
> > +++ b/drivers/of/device.c
> > @@ -19,7 +19,7 @@
> >  
> >  /**
> >   * of_match_device - Tell if a struct device matches an of_device_id list
> > - * @matches: array of of device match structures to search in
> > + * @matches: array of device match structures to search in
> 
> Hi,
> Rob has already explained this at least 2 times.
> 
> The second "of" is "open firmware".
> I would write it
>               array of OF device match structures to search in
> :)

Actually, I'd probably do something like

    	     array of Open Firmware (OF) device match structures...

This is the first place in that file (at least in a comment) where OF
gets used, and I've always been a big fan of using the fully expanded
acronym before using the acronym form.  Remember, PCMCIA stands for
People Can't Memorize Computer Industry Acronyms.  :-)

(Actually, it's Personal Computer Memory Chip Industry Association,
but most people don't know that, because using acronyms without
defining them first makes you feel like you're an "insider".  :-)

	     	      	   	    - Ted