linux-kernel - Re: [PATCH -next] drm/amd/display: make dcn32_mpc

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CADnq5_Phr_g-LZtqc2sojEqxyoqWLuo7RhFHHyC2wQsEVRBEiQ@mail.gmail.com>
Date:   Thu, 20 Oct 2022 09:12:36 -0400
From:   Alex Deucher <alexdeucher@...il.com>
To:     Harry Wentland <harry.wentland@....com>
Cc:     ruanjinjie <ruanjinjie@...wei.com>, sunpeng.li@....com,
        Rodrigo.Siqueira@....com, alexander.deucher@....com,
        christian.koenig@....com, Xinhui.Pan@....com, airlied@...il.com,
        daniel@...ll.ch, jiapeng.chong@...ux.alibaba.com,
        hanyihao@...o.com, aurabindo.pillai@....com, Martin.Leung@....com,
        amd-gfx@...ts.freedesktop.org, dri-devel@...ts.freedesktop.org,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH -next] drm/amd/display: make dcn32_mpc_funcs static

Applied.  Thanks!

Alex

On Wed, Oct 19, 2022 at 9:28 AM Harry Wentland <harry.wentland@....com> wrote:
>
> On 2022-10-19 02:23, ruanjinjie wrote:
> > The symbol is not used outside of the file, so mark it static.
> >
> > Fixes the following warning:
> >
> > drivers/gpu/drm/amd/amdgpu/../display/dc/dcn32/dcn32_mpc.c:985:24: warning:
> > symbol 'dcn32_mpc_funcs' was not declared. Should it be static?
> >
> > Signed-off-by: ruanjinjie <ruanjinjie@...wei.com>
>
> Reviewed-by: Harry Wentland <harry.wentland@....com>
>
> Harry
>
> > ---
> >  drivers/gpu/drm/amd/display/dc/dcn32/dcn32_mpc.c | 2 +-
> >  1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > diff --git a/drivers/gpu/drm/amd/display/dc/dcn32/dcn32_mpc.c b/drivers/gpu/drm/amd/display/dc/dcn32/dcn32_mpc.c
> > index 4edd0655965b..206a5ddbaf6d 100644
> > --- a/drivers/gpu/drm/amd/display/dc/dcn32/dcn32_mpc.c
> > +++ b/drivers/gpu/drm/amd/display/dc/dcn32/dcn32_mpc.c
> > @@ -982,7 +982,7 @@ static bool mpc32_program_3dlut(
> >       return true;
> >  }
> >
> > -const struct mpc_funcs dcn32_mpc_funcs = {
> > +static const struct mpc_funcs dcn32_mpc_funcs = {
> >       .read_mpcc_state = mpc1_read_mpcc_state,
> >       .insert_plane = mpc1_insert_plane,
> >       .remove_mpcc = mpc1_remove_mpcc,
>