linux-kernel - Re: [PATCH] PCI: Remove unnecessary of

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20221020134547.GA94120@bhelgaas>
Date:   Thu, 20 Oct 2022 08:45:47 -0500
From:   Bjorn Helgaas <helgaas@...nel.org>
To:     Conor Dooley <conor.dooley@...rochip.com>
Cc:     kernel test robot <lkp@...el.com>,
        Krzysztof Wilczyński <kw@...ux.com>,
        Heiko Stuebner <heiko@...ech.de>, linux-pci@...r.kernel.org,
        Lorenzo Pieralisi <lpieralisi@...nel.org>,
        llvm@...ts.linux.dev, Minghuan Lian <minghuan.Lian@....com>,
        Thierry Reding <thierry.reding@...il.com>,
        Thomas Petazzoni <thomas.petazzoni@...tlin.com>,
        Bharat Kumar Gogada <bharat.kumar.gogada@....com>,
        Toan Le <toan@...amperecomputing.com>,
        linux-riscv@...ts.infradead.org,
        Kishon Vijay Abraham I <kishon@...nel.org>,
        Rob Herring <robh@...nel.org>,
        Linus Walleij <linus.walleij@...aro.org>,
        Joyce Ooi <joyce.ooi@...el.com>,
        Jonathan Hunter <jonathanh@...dia.com>,
        linux-arm-kernel@...ts.infradead.org,
        bcm-kernel-feedback-list@...adcom.com,
        Shawn Lin <shawn.lin@...k-chips.com>,
        Ray Jui <rjui@...adcom.com>, linux-tegra@...r.kernel.org,
        linux-omap@...r.kernel.org, Mingkai Hu <mingkai.hu@....com>,
        Roy Zang <roy.zang@....com>, Michal Simek <monstr@...str.eu>,
        kbuild-all@...ts.01.org, Scott Branden <sbranden@...adcom.com>,
        Daire McNamara <daire.mcnamara@...rochip.com>,
        linux-kernel@...r.kernel.org, Tom Joseph <tjoseph@...ence.com>,
        linuxppc-dev@...ts.ozlabs.org,
        Pali Rohár <pali@...nel.org>
Subject: Re: [PATCH] PCI: Remove unnecessary of_irq.h includes

[+cc Pali, heads-up for trivial addition of <linux/irqdomain.h> to
pci-mvebu.c]

On Thu, Oct 20, 2022 at 08:20:25AM +0100, Conor Dooley wrote:
> On Thu, Oct 20, 2022 at 03:08:50PM +0800, kernel test robot wrote:
> > Hi Bjorn,
> > 
> > I love your patch! Yet something to improve:
> > 
> > >> drivers/pci/controller/pcie-microchip-host.c:473:31: error: incomplete definition of type 'struct irq_domain'
> >            struct mc_pcie *port = domain->host_data;
> 
> That's what I get for only visually inspecting the patch before Acking
> it.. Un-ack I suppose.

No problem!

I think what happened is the pcie-microchip-host.c uses
irq_domain_add_linear() so it needs <linux/irqdomain.h>, but it
currently gets it via <linux/of_irq.h>, which it doesn't otherwise
need.

I added a preparatory patch to include <linux/irqdomain.h> explicitly,
but I haven't been able to cross-build either riscv or ia64 to verify
this fix.  I'll wait a few days and post an updated series for the
0-day bot to test.

Same situation for pcie-altera-msi.c.

pci-mvebu.c also relies on getting <linux/irqdomain.h> via
<linux/of_irq.h>, but it actually depends on of_irq.h, so I'll just
add an irqdomain.h include there.

Bjorn