linux-kernel - re: wifi: rt2x00: add TX LOFT calibration for MT7620

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [thread-next>] [day] [month] [year] [list]

Message-ID: <01410678-ab7d-1733-8d5a-e06d1a4b6c9e@gmail.com>
Date:   Thu, 20 Oct 2022 14:45:22 +0100
From:   "Colin King (gmail)" <colin.i.king@...il.com>
To:     Tomislav Požega <pozega.tomislav@...il.com>
Cc:     Stanislaw Gruszka <stf_xl@...pl>,
        Helmut Schaa <helmut.schaa@...glemail.com>,
        Kalle Valo <kvalo@...nel.org>,
        "David S. Miller" <davem@...emloft.net>,
        Eric Dumazet <edumazet@...gle.com>,
        Jakub Kicinski <kuba@...nel.org>,
        Paolo Abeni <pabeni@...hat.com>,
        "linux-wireless@...r.kernel.org" <linux-wireless@...r.kernel.org>,
        "netdev@...r.kernel.org" <netdev@...r.kernel.org>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>
Subject: re: wifi: rt2x00: add TX LOFT calibration for MT7620

Hi,

I noticed a signed / unsigned comparison warning when building 
linux-next with clang. I believe it was introduced in the following commit:

commit dab902fe1d29dc0fa1dccc8d13dc89ffbf633881
Author: Tomislav Požega <pozega.tomislav@...il.com>
Date:   Sat Sep 17 21:28:43 2022 +0100

     wifi: rt2x00: add TX LOFT calibration for MT7620


The warning is as follows:

drivers/net/wireless/ralink/rt2x00/rt2800lib.c:9472:15: warning: result 
of comparison of constant -7 with expression of type 'char' is always 
false [-Wtautological-constant-out-of-range-compare]
         gerr = (gerr < -0x07) ? -0x07 : (gerr > 0x05) ? 0x05 : gerr;
                 ~~~~ ^ ~~~~~
drivers/net/wireless/ralink/rt2x00/rt2800lib.c:9476:15: warning: result 
of comparison of constant -31 with expression of type 'char' is always 
false [-Wtautological-constant-out-of-range-compare]
         perr = (perr < -0x1f) ? -0x1f : (perr > 0x1d) ? 0x1d : perr;
                 ~~~~ ^ ~~~~~

The variables gerr and perr are declared as a char, which in this case 
seems to be defaulting to signed on the clang build for x86-64 and hence 
this warning. I suspect making it signed char will do the trick, but I 
wanted to flag this up in-case there were some other issues with making 
them signed.

Colin