linux-kernel - Re: [PATCH] mmc: add TS7800 FPGA based MMC controller driver

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <ef23d179-15fa-4ad9-8ddc-ccad7790f8d0@app.fastmail.com>
Date:   Thu, 20 Oct 2022 16:44:31 +0200
From:   "Arnd Bergmann" <arnd@...db.de>
To:     "Firas Ashkar" <firas.ashkar@...oirfairelinux.com>,
        alex@...riz.org.uk, "Ulf Hansson" <ulf.hansson@...aro.org>
Cc:     linux-arm-kernel@...ts.infradead.org,
        "linux-mmc @ vger . kernel . org" <linux-mmc@...r.kernel.org>,
        linux-kernel <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] mmc: add TS7800 FPGA based MMC controller driver

On Thu, Oct 20, 2022, at 16:42, firas ashkar wrote:
>> 
>> > +
>> > +#define DRIVER_NAME "ts7800v1_sdmmc"
>> 
>> Maybe drop this macro and just use the string directly.
> This define macro used in multiple locations

Yes, exactly that is the problem. Other drivers use the
same macro name, so it's very hard to grep for the actual
string.

    Arnd