linux-kernel - Re: [PATCH v5 06/10] pwm: dwc: split pci out of core driver

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <72d561c9-e2cd-83b7-bd47-ebba5ad571f0@sifive.com>
Date:   Thu, 20 Oct 2022 15:47:39 +0100
From:   Ben Dooks <ben.dooks@...ive.com>
To:     Jarkko Nikula <jarkko.nikula@...ux.intel.com>,
        linux-pwm@...r.kernel.org
Cc:     devicetree@...r.kernel.org, linux-kernel@...r.kernel.org,
        Lee Jones <lee.jones@...aro.org>,
        u.kleine-koenig@...gutronix.de,
        Thierry Reding <thierry.reding@...il.com>,
        Krzysztof Kozlowski <krzysztof.kozlowski+dt@...aro.org>,
        Greentime Hu <greentime.hu@...ive.com>,
        William Salmon <william.salmon@...ive.com>,
        Jude Onyenegecha <jude.onyenegecha@...ive.com>
Subject: Re: [PATCH v5 06/10] pwm: dwc: split pci out of core driver

On 10/10/2022 11:39, Jarkko Nikula wrote:
> Hi
> 
> On 10/6/22 01:12, Ben Dooks wrote:
>> Moving towards adding non-pci support for the driver, move the pci
>> parts out of the core into their own module. This is partly due to
>> the module_driver() code only being allowed once in a module and also
>> to avoid a number of #ifdef if we build a single file in a system
>> without pci support.
>>
>> Signed-off-by: Ben Dooks <ben.dooks@...ive.com>
>> ---
>> v4:
>>   - removed DWC_PERIOD_NS as not needed
> 
> ...
> 
>> --- a/drivers/pwm/pwm-dwc.c
>> +++ b/drivers/pwm/pwm-dwc.c
>> -
>> -#define DWC_TIMERS_TOTAL    8
>> -#define DWC_CLK_PERIOD_NS    10
>> -
> 
> Actually DWC_CLK_PERIOD_NS is still used here. Only the next patch 07/10 
> is removing usage of it so this patch is not bisect safe.

Ok, will fix for v6.