linux-kernel - Re: wifi: rt2x00: add TX LOFT calibration for MT7620

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <e1fc572c-2a02-26e7-ab3f-54133636462d@gmail.com>
Date:   Thu, 20 Oct 2022 16:16:32 +0100
From:   "Colin King (gmail)" <colin.i.king@...il.com>
To:     Stanislaw Gruszka <stf_xl@...pl>
Cc:     Tomislav Požega <pozega.tomislav@...il.com>,
        Helmut Schaa <helmut.schaa@...glemail.com>,
        Kalle Valo <kvalo@...nel.org>,
        "David S. Miller" <davem@...emloft.net>,
        Eric Dumazet <edumazet@...gle.com>,
        Jakub Kicinski <kuba@...nel.org>,
        Paolo Abeni <pabeni@...hat.com>,
        "linux-wireless@...r.kernel.org" <linux-wireless@...r.kernel.org>,
        "netdev@...r.kernel.org" <netdev@...r.kernel.org>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>
Subject: Re: wifi: rt2x00: add TX LOFT calibration for MT7620

On 20/10/2022 16:15, Stanislaw Gruszka wrote:
> On Thu, Oct 20, 2022 at 02:45:22PM +0100, Colin King (gmail) wrote:
>> I noticed a signed / unsigned comparison warning when building linux-next
>> with clang. I believe it was introduced in the following commit:
>>
>> commit dab902fe1d29dc0fa1dccc8d13dc89ffbf633881
>> Author: Tomislav Požega <pozega.tomislav@...il.com>
>> Date:   Sat Sep 17 21:28:43 2022 +0100
>>
>>      wifi: rt2x00: add TX LOFT calibration for MT7620
>>
>>
>> The warning is as follows:
>>
>> drivers/net/wireless/ralink/rt2x00/rt2800lib.c:9472:15: warning: result of
>> comparison of constant -7 with expression of type 'char' is always false
>> [-Wtautological-constant-out-of-range-compare]
>>          gerr = (gerr < -0x07) ? -0x07 : (gerr > 0x05) ? 0x05 : gerr;
> 
> This was very currently addressed:
> https://lore.kernel.org/linux-wireless/20221019155541.3410813-1-Jason@zx2c4.com/

Awesome. Thanks!

Colin
> 
> Regards
> Stanislaw