[<prev] [next>] [<thread-prev] [day] [month] [year] [list]
Message-ID: <20221020153101.425njbgquuu6ezv3@revolver>
Date: Thu, 20 Oct 2022 15:31:25 +0000
From: Liam Howlett <liam.howlett@...cle.com>
To: Hugh Dickins <hughd@...gle.com>
CC: Andrew Morton <akpm@...ux-foundation.org>,
Matthew Wilcox <willy@...radead.org>,
Alexey Dobriyan <adobriyan@...il.com>,
Seth Jenkins <sethjenkins@...gle.com>,
Vlastimil Babka <vbabka@...e.cz>,
"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
"linux-mm@...ck.org" <linux-mm@...ck.org>
Subject: Re: [PATCH] mm: /proc/pid/smaps_rollup: fix maple tree search
Thanks Hugh. I guess this 'optimisation' was a little more aggressive
and a little more buggy than needed.
Reviewed-by: Liam R. Howlett <Liam.Howlett@...cle.com>
* Hugh Dickins <hughd@...gle.com> [221018 23:18]:
> /proc/pid/smaps_rollup showed 0 kB for everything: now find first vma.
>
> Fixes: c4c84f06285e ("fs/proc/task_mmu: stop using linked list and highest_vm_end")
> Signed-off-by: Hugh Dickins <hughd@...gle.com>
> ---
>
> fs/proc/task_mmu.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> --- 6.1-rc1/fs/proc/task_mmu.c
> +++ linux/fs/proc/task_mmu.c
> @@ -902,7 +902,7 @@ static int show_smaps_rollup(struct seq_
> goto out_put_mm;
>
> hold_task_mempolicy(priv);
> - vma = mas_find(&mas, 0);
> + vma = mas_find(&mas, ULONG_MAX);
>
> if (unlikely(!vma))
> goto empty_set;
Powered by blists - more mailing lists