linux-kernel - Re: [PATCH] trace/ring_buffer: remove unused arguments

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20221020114348.40fe9644@gandalf.local.home>
Date:   Thu, 20 Oct 2022 11:43:48 -0400
From:   Steven Rostedt <rostedt@...dmis.org>
To:     chensong <chensong_2000@....cn>
Cc:     mingo@...hat.com, mhiramat@...nel.org,
        linux-kernel@...r.kernel.org, xiehuan09@...il.com
Subject: Re: [PATCH] trace/ring_buffer: remove unused arguments

On Thu, 20 Oct 2022 23:25:56 +0800
chensong <chensong_2000@....cn> wrote:

> > I guess this doesn't hurt.
> 
> I was reading __kprobe_trace_func, store_trace_args stores args in 
> fbuffer.entry,which is event->array, but at the end, rb_commit uses 
> fbuffer.buffer instead of event.
> 
> Then i thought, if it's useless, why not just clean it up.


I meant your change probably doesn't hurt.

-- Steve