linux-kernel - Re: [PATCH 1/1] kernel/utsname_sysctl.c: Add missing enum uts

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <Y1FveWRHUA0nz8n8@kroah.com>
Date:   Thu, 20 Oct 2022 17:55:37 +0200
From:   Greg Kroah-Hartman <gregkh@...uxfoundation.org>
To:     Petr Vorel <pvorel@...e.cz>
Cc:     linux-kernel@...r.kernel.org,
        Andrew Morton <akpm@...ux-foundation.org>,
        Torsten Hilbrich <torsten.hilbrich@...unet.com>
Subject: Re: [PATCH 1/1] kernel/utsname_sysctl.c: Add missing enum uts_proc
 value

On Thu, Oct 20, 2022 at 05:06:45PM +0200, Petr Vorel wrote:
> bfca3dd3d068 added new struct ctl_table uts_kern_table[], but not new
> enum uts_proc value. It broke the notification mechanism between the
> sethostname syscall and the pollers of /proc/sys/kernel/hostname.
> 
> The table uts_kern_table is addressed within uts_proc_notify by the enum
> value, that's why new enum value is needed.
> 
> Fixes: bfca3dd3d068 ("kernel/utsname_sysctl.c: print kernel arch")
> 
> Reported-by: Torsten Hilbrich <torsten.hilbrich@...unet.com>
> Signed-off-by: Petr Vorel <pvorel@...e.cz>
> ---
> Hi all,
> 
> I'm sorry to introduce a regression.
> 
> Torsten Hilbrich reported [1] that hostnamectl set-hostname foo
> which does poll() got affected by bfca3dd3d068. He also wrote a
> reproducer [2] which does not require systemd, I tested the patch on
> dracut initramfs.

Thanks for the quick response, I'll queue this up in my tree now.

greg k-h