linux-kernel - RE: [Patch v8 12/12] RDMA/mana_ib: Add a driver for Microsoft Azure Network Adapter

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <PH7PR21MB3263C613FF4CC1CAD5F126EFCE2D9@PH7PR21MB3263.namprd21.prod.outlook.com>
Date:   Fri, 21 Oct 2022 23:32:20 +0000
From:   Long Li <longli@...rosoft.com>
To:     Bernard Metzler <BMT@...ich.ibm.com>,
        KY Srinivasan <kys@...rosoft.com>,
        Haiyang Zhang <haiyangz@...rosoft.com>,
        Stephen Hemminger <sthemmin@...rosoft.com>,
        Wei Liu <wei.liu@...nel.org>, Dexuan Cui <decui@...rosoft.com>,
        "David S. Miller" <davem@...emloft.net>,
        Jakub Kicinski <kuba@...nel.org>,
        Paolo Abeni <pabeni@...hat.com>,
        Jason Gunthorpe <jgg@...pe.ca>,
        Leon Romanovsky <leon@...nel.org>,
        "edumazet@...gle.com" <edumazet@...gle.com>,
        "shiraz.saleem@...el.com" <shiraz.saleem@...el.com>,
        Ajay Sharma <sharmaajay@...rosoft.com>
CC:     "linux-hyperv@...r.kernel.org" <linux-hyperv@...r.kernel.org>,
        "netdev@...r.kernel.org" <netdev@...r.kernel.org>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
        "linux-rdma@...r.kernel.org" <linux-rdma@...r.kernel.org>
Subject: RE: [Patch v8 12/12] RDMA/mana_ib: Add a driver for Microsoft Azure
 Network Adapter

> > For good reasons there are no abstract interface specifications in Linux
> kernel.
> > I was just wondering if it is good to leave concrete attributes which
> > are not
> > (yet?) reported at random. It is obviously working okay today for your
> > environment.
> > But memset zero everything you don't care about today might be just
> > safe to detect an unexpected interpretation of those fields in the future?
> >
> >
> > Thanks,
> > Bernard.
> 
> Thank you for the pointer.
> 
> I'm making the changes as you suggested.
> 
> Long

Went through the code that IB upper layer calls query_xxx into lower driver.
It seems the upper layer always zero out the values (or set them) before calling.

I think we should be safe for the code as is.