[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <cccebca9-69a9-523c-dd5e-85d17f0946b6@somainline.org>
Date: Sat, 22 Oct 2022 01:57:38 +0200
From: Konrad Dybcio <konrad.dybcio@...ainline.org>
To: asahi@...ts.linux.dev, Hector Martin <marcan@...can.st>,
Sven Peter <sven@...npeter.dev>,
Alyssa Rosenzweig <alyssa@...enzweig.io>
Cc: Thomas Gleixner <tglx@...utronix.de>,
Marc Zyngier <maz@...nel.org>,
linux-arm-kernel@...ts.infradead.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] irqchip/apple-aic: Mark aic_info structs __initconst
On 22.10.2022 01:55, Konrad Dybcio wrote:
> These structs hold information used only at init time that never
> gets modified, hence mark them __initconst.
>
> Signed-off-by: Konrad Dybcio <konrad.dybcio@...ainline.org>
> ---
Forgot to add:
Suggested-by: Marc Zyngier <maz@...nel.org>
Konrad
> drivers/irqchip/irq-apple-aic.c | 6 +++---
> 1 file changed, 3 insertions(+), 3 deletions(-)
>
> diff --git a/drivers/irqchip/irq-apple-aic.c b/drivers/irqchip/irq-apple-aic.c
> index 1c2813ad8bbe..ae3437f03e6c 100644
> --- a/drivers/irqchip/irq-apple-aic.c
> +++ b/drivers/irqchip/irq-apple-aic.c
> @@ -248,14 +248,14 @@ struct aic_info {
> bool fast_ipi;
> };
>
> -static const struct aic_info aic1_info = {
> +static const struct aic_info aic1_info __initconst = {
> .version = 1,
>
> .event = AIC_EVENT,
> .target_cpu = AIC_TARGET_CPU,
> };
>
> -static const struct aic_info aic1_fipi_info = {
> +static const struct aic_info aic1_fipi_info __initconst = {
> .version = 1,
>
> .event = AIC_EVENT,
> @@ -264,7 +264,7 @@ static const struct aic_info aic1_fipi_info = {
> .fast_ipi = true,
> };
>
> -static const struct aic_info aic2_info = {
> +static const struct aic_info aic2_info __initconst = {
> .version = 2,
>
> .irq_cfg = AIC2_IRQ_CFG,
Powered by blists - more mailing lists